-
Notifications
You must be signed in to change notification settings - Fork 9
Annotated for each #974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Annotated for each #974
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #974 +/- ##
==========================================
+ Coverage 91.76% 91.85% +0.09%
==========================================
Files 57 57
Lines 2756 2788 +32
Branches 924 927 +3
==========================================
+ Hits 2529 2561 +32
Misses 136 136
Partials 91 91 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tpadioleau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the implementations so that they can support iterating over other kind of domains, like a DiscreteSparseDomain. A copy paste of for_each_serial/transform_reduce_serial should be enough.
|
I put it back to draft the time to make the changes. |
PR to merge the work of @blegouix done in #708.
I can't update the original PR since I don't have writing rights over https://github.com/blegouix/ddc/ nor https://github.com/CExA-project/ddc.