Q (bug?): Garbled data on complex sketches - (concurrency?) isssue in DcsBiosNgRS485Slave.cpp.inc

[krorvik]

I am seeing garbled string data (F-16 DED) , and randomly firing LEDs in complex sketches.

According to this comment from the DCS forums (credit BoboBear):

https://forum.dcs.world/topic/208455-dcs-bios-over-rs485/page/3/#comment-4374711

There seems to be an unreported issue In function:

void RS485Slave::rxISR()

I tested the fix mentioned in the issue, that is, set the state before processing - and this indeed seems to fix the problem. The RX_WAIT_DATA case is changed to look like this:

case RX_WAIT_DATA: rxtx_len--; if (rxtx_len == 0) { state = RX_WAIT_CHECKSUM; } if (rx_datatype == RXDATA_DCSBIOS_EXPORT) { parser.processCharISR(c); } break;

Should this be considered as a patch?

[krorvik]

Making this a question for now since I do not have the knowledge to evaluate any other effects.

[maciekish]

Im seeing the same issue with a slow drawing LCD. Serial buffer too small? Incorrect interrupt handling? Any ideas?