Skip to content

Commit 622c990

Browse files
randmonkeyczeslavo
andauthored
fix: print concrete error from fillPlugin in logs (#5346)
* fix: print concrete error from fillPlugin in logs * Use `WithError` Co-authored-by: Grzegorz Burzyński <czeslavo@gmail.com> --------- Co-authored-by: Grzegorz Burzyński <czeslavo@gmail.com>
1 parent d1a3a81 commit 622c990

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

internal/dataplane/deckgen/generate.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ func ToDeckContent(
5353
}
5454
err = fillPlugin(ctx, &plugin, params.PluginSchemas)
5555
if err != nil {
56-
log.Errorf("failed to fill-in defaults for plugin: %s", *plugin.Name)
56+
log.WithError(err).Errorf("failed to fill-in defaults for plugin: %s", *plugin.Name)
5757
}
5858
service.Plugins = append(service.Plugins, &plugin)
5959
sort.SliceStable(service.Plugins, func(i, j int) bool {
@@ -71,7 +71,7 @@ func ToDeckContent(
7171
}
7272
err = fillPlugin(ctx, &plugin, params.PluginSchemas)
7373
if err != nil {
74-
log.Errorf("failed to fill-in defaults for plugin: %s", *plugin.Name)
74+
log.WithError(err).Errorf("failed to fill-in defaults for plugin: %s", *plugin.Name)
7575
}
7676
route.Plugins = append(route.Plugins, &plugin)
7777
sort.SliceStable(route.Plugins, func(i, j int) bool {
@@ -95,7 +95,7 @@ func ToDeckContent(
9595
}
9696
err = fillPlugin(ctx, &plugin, params.PluginSchemas)
9797
if err != nil {
98-
log.Errorf("failed to fill-in defaults for plugin: %s", *plugin.Name)
98+
log.WithError(err).Errorf("failed to fill-in defaults for plugin: %s", *plugin.Name)
9999
}
100100
content.Plugins = append(content.Plugins, plugin)
101101
}

0 commit comments

Comments
 (0)