chore(api): Retrieve DEFAULT_RATE_LIMIT_PER_MIN using zod #5077
+4
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing usage of
DEFAULT_RATE_LIMIT_PER_MINenv var had 2 issuesThis PR addresses both of these. The default value is set to 200, which is our current base default, but only for type-safety reasons. We make sure to set this value in all services and environments that would use this variable regardless.
Switch rate-limit default to zod-parsed env & lower fallback value
Replaces direct
process.envaccess with typed retrieval viaenvsobject and adjusts the fallback value ofDEFAULT_RATE_LIMIT_PER_MINfrom 3500 to 200. Keeps rate-limiter logic unchanged otherwise and aligns with the codebase’s standard zod-based env parsing.Key Changes
• Removed inline parsing of
process.env['DEFAULT_RATE_LIMIT_PER_MIN']inpackages/server/lib/middleware/ratelimit.middleware.ts• Added
envs.DEFAULT_RATE_LIMIT_PER_MINimport and usage• Updated zod schema in
packages/utils/lib/environment/parse.tsto.default(200)instead of leaving undefined or defaulting in codeAffected Areas
•
packages/server/lib/middleware/ratelimit.middleware.ts•
packages/utils/lib/environment/parse.tsThis summary was automatically generated by @propel-code-bot