fix: use non-boolean columns in multi-column orderBy e2e tests

Electric/PostgreSQL doesn't support comparison operators (<, >, <=, >=)
on boolean types. Changed tests to use age (number) and name (string)
columns instead of isActive (boolean) to avoid this limitation.

The core multi-column orderBy functionality still works correctly -
this is just a test adjustment to work within Electric's SQL parser
constraints.

Author: samwillis

packages/db-collection-e2e/src/suites/pagination.suite.ts

@@ -406,11 +406,12 @@ export function createPaginationTestSuite(
         const usersCollection = config.collections.onDemand.users
 
         // Create query with multi-column orderBy and limit
+        // Using age (number) and name (string) to avoid boolean comparison issues
         const query = createLiveQueryCollection((q) =>
           q
             .from({ user: usersCollection })
-            .orderBy(({ user }) => user.isActive, `desc`)
             .orderBy(({ user }) => user.age, `asc`)
+            .orderBy(({ user }) => user.name, `asc`)
             .limit(10)
         )
 
@@ -421,16 +422,14 @@ export function createPaginationTestSuite(
         const firstPage = Array.from(query.state.values())
         expect(firstPage).toHaveLength(10)
 
-        // Verify first page ordering
+        // Verify first page ordering (age asc, then name asc)
         for (let i = 1; i < firstPage.length; i++) {
           const prev = firstPage[i - 1]!
           const curr = firstPage[i]!
-          if (prev.isActive !== curr.isActive) {
-            expect(prev.isActive ? 1 : 0).toBeGreaterThanOrEqual(
-              curr.isActive ? 1 : 0
-            )
-          } else {
+          if (prev.age !== curr.age) {
             expect(prev.age).toBeLessThanOrEqual(curr.age)
+          } else {
+            expect(prev.name.localeCompare(curr.name)).toBeLessThanOrEqual(0)
           }
         }
 
@@ -455,12 +454,10 @@ export function createPaginationTestSuite(
         for (let i = 1; i < secondPage.length; i++) {
           const prev = secondPage[i - 1]!
           const curr = secondPage[i]!
-          if (prev.isActive !== curr.isActive) {
-            expect(prev.isActive ? 1 : 0).toBeGreaterThanOrEqual(
-              curr.isActive ? 1 : 0
-            )
-          } else {
+          if (prev.age !== curr.age) {
             expect(prev.age).toBeLessThanOrEqual(curr.age)
+          } else {
+            expect(prev.name.localeCompare(curr.name)).toBeLessThanOrEqual(0)
           }
         }
 
@@ -483,8 +480,8 @@ export function createPaginationTestSuite(
         const query = createLiveQueryCollection((q) =>
           q
             .from({ user: usersCollection })
-            .orderBy(({ user }) => user.isActive, `desc`)
             .orderBy(({ user }) => user.age, `asc`)
+            .orderBy(({ user }) => user.name, `asc`)
             .limit(10)
             .offset(20)
         )
@@ -512,16 +509,14 @@ export function createPaginationTestSuite(
           expect(laterPageIds.has(id)).toBe(false)
         }
 
-        // Verify ordering on earlier page
+        // Verify ordering on earlier page (age asc, name asc)
         for (let i = 1; i < earlierPage.length; i++) {
           const prev = earlierPage[i - 1]!
           const curr = earlierPage[i]!
-          if (prev.isActive !== curr.isActive) {
-            expect(prev.isActive ? 1 : 0).toBeGreaterThanOrEqual(
-              curr.isActive ? 1 : 0
-            )
-          } else {
+          if (prev.age !== curr.age) {
             expect(prev.age).toBeLessThanOrEqual(curr.age)
+          } else {
+            expect(prev.name.localeCompare(curr.name)).toBeLessThanOrEqual(0)
           }
         }
 
@@ -582,13 +577,13 @@ export function createPaginationTestSuite(
         const config = await getConfig()
         const usersCollection = config.collections.onDemand.users
 
-        // isActive has only 2 values (true/false), so many duplicates in first column
+        // Age has limited unique values in test data, so many duplicates in first column
         // This tests that the composite cursor correctly handles paging across duplicates
         const query = createLiveQueryCollection((q) =>
           q
             .from({ user: usersCollection })
-            .orderBy(({ user }) => user.isActive, `desc`)
             .orderBy(({ user }) => user.age, `asc`)
+            .orderBy(({ user }) => user.name, `asc`)
             .limit(20)
         )
 
@@ -612,12 +607,10 @@ export function createPaginationTestSuite(
         for (let i = 1; i < secondPage.length; i++) {
           const prev = secondPage[i - 1]!
           const curr = secondPage[i]!
-          if (prev.isActive !== curr.isActive) {
-            expect(prev.isActive ? 1 : 0).toBeGreaterThanOrEqual(
-              curr.isActive ? 1 : 0
-            )
-          } else {
+          if (prev.age !== curr.age) {
             expect(prev.age).toBeLessThanOrEqual(curr.age)
+          } else {
+            expect(prev.name.localeCompare(curr.name)).toBeLessThanOrEqual(0)
           }
         }
 
@@ -659,8 +652,8 @@ export function createPaginationTestSuite(
         const query = createLiveQueryCollection((q) =>
           q
             .from({ user: usersCollection })
-            .orderBy(({ user }) => user.isActive, `desc`)
             .orderBy(({ user }) => user.age, `asc`)
+            .orderBy(({ user }) => user.name, `asc`)
             .limit(5)
         )
 
@@ -703,17 +696,17 @@ export function createPaginationTestSuite(
         const firstItemSecondPage = secondPage[0]!
 
         // The first item of page 2 should come after the last item of page 1
-        // in the sort order (isActive desc, age asc)
-        if (lastItemFirstPage.isActive === firstItemSecondPage.isActive) {
-          // Same isActive value, so age should be greater or equal
+        // in the sort order (age asc, name asc)
+        if (lastItemFirstPage.age === firstItemSecondPage.age) {
+          // Same age value, so name should be greater or equal
+          expect(
+            firstItemSecondPage.name.localeCompare(lastItemFirstPage.name)
+          ).toBeGreaterThanOrEqual(0)
+        } else {
+          // Different age, page 2 first should have greater or equal age
           expect(firstItemSecondPage.age).toBeGreaterThanOrEqual(
             lastItemFirstPage.age
           )
-        } else {
-          // Different isActive, page 1 last should be true, page 2 first should be false
-          // (since isActive is desc, true comes before false)
-          expect(lastItemFirstPage.isActive).toBe(true)
-          expect(firstItemSecondPage.isActive).toBe(false)
         }
 
         await query.cleanup()