Remember last sim #135
Remember last sim #135
Conversation
…r command to save info for last simulation
…ote machine and do some operations
… executation has a different working dir, all files will be saved to workbenchproject not target. 2. now the check last simulation can check if the simulation from last time is completed
…m. Including simulation, provMgv, and the model inside, and can write the model correctly. However, due to the space in my username, it cannot read the model. The problem can be solved by removing the space.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
checkstyle
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|433 col 11| 'try rcurly' has incorrect indentation level 10, expected level should be 6.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|434 col 13| 'catch' child has incorrect indentation level 12, expected level should be 8.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|435 col 11| 'catch rcurly' has incorrect indentation level 10, expected level should be 6.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|436 col 9| 'if rcurly' has incorrect indentation level 8, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/ui/LoginCredentialsDialog.java|18 col 1| Line contains a tab character.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/model/SimulationSpecification.java|5 col 1| Extra separation in import group before 'java.io.Serializable'
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/FileManager.java|193 col 9| 'method def' child has incorrect indentation level 8, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|12 col 1| Extra separation in import group before 'edu.uwb.braingrid.workbench.WorkbenchManager'
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|17 col 1| Extra separation in import group before 'java.io.BufferedReader'
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|17 col 1| Wrong lexicographical order for 'java.io.BufferedReader' import. Should be before 'riotcmd.infer'.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|23 col 1| Wrong lexicographical order for 'java.io.InputStreamReader' import. Should be before 'riotcmd.infer'.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|26 col 1| Extra separation in import group before 'javax.swing.JFrame'
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|26 col 1| Wrong lexicographical order for 'javax.swing.JFrame' import. Should be before 'riotcmd.infer'.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|27 col 1| Wrong lexicographical order for 'javax.swing.JOptionPane' import. Should be before 'riotcmd.infer'.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|289 col 5| Block comment has incorrect indentation level 4, expected is 2, indentation should be the same level as line 299.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|314 col 5| 'try' has incorrect indentation level 4, expected level should be 6.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|320 col 15| 'if' child has incorrect indentation level 14, expected level should be 12.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|321 col 15| 'if' child has incorrect indentation level 14, expected level should be 12.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|323 col 15| 'try' has incorrect indentation level 14, expected level should be 12.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|324 col 17| 'try' child has incorrect indentation level 16, expected level should be 14.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|326 col 17| 'try' child has incorrect indentation level 16, expected level should be 14.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|326 col 29| Abbreviation in name 'workBenchLOG' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|327 col 17| 'try' child has incorrect indentation level 16, expected level should be 14.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|327 col 32| Abbreviation in name 'readLOG' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|328 col 17| 'try' child has incorrect indentation level 16, expected level should be 14.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|329 col 17| 'try' child has incorrect indentation level 16, expected level should be 14.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|330 col 17| 'while' has incorrect indentation level 16, expected level should be 14.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|331 col 21| 'while' child has incorrect indentation level 20, expected level should be 16.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|332 col 17| 'while rcurly' has incorrect indentation level 16, expected level should be 14.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|333 col 17| 'try' child has incorrect indentation level 16, expected level should be 14.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|334 col 17| 'try' child has incorrect indentation level 16, expected level should be 14.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|336 col 17| 'if' has incorrect indentation level 16, expected level should be 14.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|337 col 19| 'if' child has incorrect indentation level 18, expected level should be 16.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|338 col 19| 'if' child has incorrect indentation level 18, expected level should be 16.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|339 col 17| 'if rcurly' has incorrect indentation level 16, expected level should be 14.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|345 col 5| 'try rcurly' has incorrect indentation level 4, expected level should be 6.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|346 col 7| 'catch' child has incorrect indentation level 6, expected level should be 8.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|347 col 5| 'catch rcurly' has incorrect indentation level 4, expected level should be 6.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|361 col 7| 'if' has incorrect indentation level 6, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|362 col 9| 'if' child has incorrect indentation level 8, expected level should be 6.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|364 col 7| 'if rcurly' has incorrect indentation level 6, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|75 col 5| Block comment has incorrect indentation level 4, expected is 2, indentation should be the same level as line 81.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|81 col 17| Abbreviation in name 'getProvURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|82 col 7| 'method def' child has incorrect indentation level 6, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|85 col 5| Block comment has incorrect indentation level 4, expected is 2, indentation should be the same level as line 91.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|91 col 17| Abbreviation in name 'getLocalURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|92 col 6| 'method def' child has incorrect indentation level 5, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|95 col 5| Block comment has incorrect indentation level 4, expected is 2, indentation should be the same level as line 101.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|101 col 17| Abbreviation in name 'getRemoteURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|103 col 5| 'method def rcurly' has incorrect indentation level 4, expected level should be 2.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|112 col 3| 'CTOR_DEF' should be separated from previous line.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|112 col 25| Abbreviation in name 'provURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|112 col 41| Abbreviation in name 'localURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|112 col 58| Abbreviation in name 'remoteURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|117 col 5| 'ctor def rcurly' has incorrect indentation level 4, expected level should be 2.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|16 col 1| Extra separation in import group before 'javax.swing.JFrame'
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|19 col 1| Extra separation in import group before 'org.apache.jena.rdf.model.Model'
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|23 col 1| Extra separation in import group before 'com.fasterxml.jackson.databind.ObjectMapper'
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|23 col 1| Wrong lexicographical order for 'com.fasterxml.jackson.databind.ObjectMapper' import. Should be before 'org.eclipse.jgit.transport.CredentialItem.Username'.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|33 col 1| Wrong lexicographical order for 'edu.uwb.braingrid.provenance.ProvMgr' import. Should be before 'org.eclipse.jgit.transport.CredentialItem.Username'.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|36 col 1| Wrong lexicographical order for 'edu.uwb.braingrid.workbench.comm.SecureFileTransfer' import. Should be before 'org.eclipse.jgit.transport.CredentialItem.Username'.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|37 col 1| Wrong lexicographical order for 'edu.uwb.braingrid.workbench.model.Simulation' import. Should be before 'org.eclipse.jgit.transport.CredentialItem.Username'.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|38 col 1| Wrong lexicographical order for 'edu.uwb.braingrid.workbench.ui.LoginCredentialsDialog' import. Should be before 'org.eclipse.jgit.transport.CredentialItem.Username'.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|39 col 1| Wrong lexicographical order for 'edu.uwb.braingrid.workbench.ui.SimulationSpecificationDialog' import. Should be before 'org.eclipse.jgit.transport.CredentialItem.Username'.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|155 col 9| 'method def' child has incorrect indentation level 8, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|156 col 5| 'method def rcurly' has incorrect indentation level 4, expected level should be 2.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|199 col 15| Distance between variable 'simName' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|202 col 15| Distance between variable 'username' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|203 col 15| Distance between variable 'password' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|204 col 15| Distance between variable 'fileTransfer' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|210 col 30| Abbreviation in name 'readURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|212 col 22| Abbreviation in name 'provURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|213 col 22| Abbreviation in name 'localURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|214 col 22| Abbreviation in name 'remoteURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|217 col 1| Comment has incorrect indentation level 0, expected is 14, indentation should be the same level as line 218.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/WorkbenchManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/WorkbenchManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/WorkbenchManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/WorkbenchManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/WorkbenchManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
checkstyle
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|328 col 17| 'try' child has incorrect indentation level 16, expected level should be 14.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|329 col 17| 'try' child has incorrect indentation level 16, expected level should be 14.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|330 col 17| 'while' has incorrect indentation level 16, expected level should be 14.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|331 col 21| 'while' child has incorrect indentation level 20, expected level should be 16.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|332 col 17| 'while rcurly' has incorrect indentation level 16, expected level should be 14.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|333 col 17| 'try' child has incorrect indentation level 16, expected level should be 14.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|334 col 17| 'try' child has incorrect indentation level 16, expected level should be 14.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|336 col 17| 'if' has incorrect indentation level 16, expected level should be 14.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|337 col 19| 'if' child has incorrect indentation level 18, expected level should be 16.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|338 col 19| 'if' child has incorrect indentation level 18, expected level should be 16.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|339 col 17| 'if rcurly' has incorrect indentation level 16, expected level should be 14.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|345 col 5| 'try rcurly' has incorrect indentation level 4, expected level should be 6.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|346 col 7| 'catch' child has incorrect indentation level 6, expected level should be 8.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|347 col 5| 'catch rcurly' has incorrect indentation level 4, expected level should be 6.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|361 col 7| 'if' has incorrect indentation level 6, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|362 col 9| 'if' child has incorrect indentation level 8, expected level should be 6.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|364 col 7| 'if rcurly' has incorrect indentation level 6, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|75 col 5| Block comment has incorrect indentation level 4, expected is 2, indentation should be the same level as line 81.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|81 col 17| Abbreviation in name 'getProvURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|82 col 7| 'method def' child has incorrect indentation level 6, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|85 col 5| Block comment has incorrect indentation level 4, expected is 2, indentation should be the same level as line 91.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|91 col 17| Abbreviation in name 'getLocalURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|92 col 6| 'method def' child has incorrect indentation level 5, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|95 col 5| Block comment has incorrect indentation level 4, expected is 2, indentation should be the same level as line 101.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|101 col 17| Abbreviation in name 'getRemoteURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|103 col 5| 'method def rcurly' has incorrect indentation level 4, expected level should be 2.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|112 col 3| 'CTOR_DEF' should be separated from previous line.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|112 col 25| Abbreviation in name 'provURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|112 col 41| Abbreviation in name 'localURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|112 col 58| Abbreviation in name 'remoteURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|117 col 5| 'ctor def rcurly' has incorrect indentation level 4, expected level should be 2.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|16 col 1| Extra separation in import group before 'javax.swing.JFrame'
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|19 col 1| Extra separation in import group before 'org.apache.jena.rdf.model.Model'
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|23 col 1| Extra separation in import group before 'com.fasterxml.jackson.databind.ObjectMapper'
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|23 col 1| Wrong lexicographical order for 'com.fasterxml.jackson.databind.ObjectMapper' import. Should be before 'org.eclipse.jgit.transport.CredentialItem.Username'.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|33 col 1| Wrong lexicographical order for 'edu.uwb.braingrid.provenance.ProvMgr' import. Should be before 'org.eclipse.jgit.transport.CredentialItem.Username'.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|36 col 1| Wrong lexicographical order for 'edu.uwb.braingrid.workbench.comm.SecureFileTransfer' import. Should be before 'org.eclipse.jgit.transport.CredentialItem.Username'.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|37 col 1| Wrong lexicographical order for 'edu.uwb.braingrid.workbench.model.Simulation' import. Should be before 'org.eclipse.jgit.transport.CredentialItem.Username'.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|38 col 1| Wrong lexicographical order for 'edu.uwb.braingrid.workbench.ui.LoginCredentialsDialog' import. Should be before 'org.eclipse.jgit.transport.CredentialItem.Username'.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|39 col 1| Wrong lexicographical order for 'edu.uwb.braingrid.workbench.ui.SimulationSpecificationDialog' import. Should be before 'org.eclipse.jgit.transport.CredentialItem.Username'.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|155 col 9| 'method def' child has incorrect indentation level 8, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|156 col 5| 'method def rcurly' has incorrect indentation level 4, expected level should be 2.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|199 col 15| Distance between variable 'simName' declaration and its first usage is 5, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|202 col 15| Distance between variable 'username' declaration and its first usage is 5, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|203 col 15| Distance between variable 'password' declaration and its first usage is 5, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|204 col 15| Distance between variable 'fileTransfer' declaration and its first usage is 5, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|210 col 30| Abbreviation in name 'readURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|212 col 22| Abbreviation in name 'provURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|213 col 22| Abbreviation in name 'localURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|214 col 22| Abbreviation in name 'remoteURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|217 col 1| Comment has incorrect indentation level 0, expected is 14, indentation should be the same level as line 218.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/WorkbenchManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/WorkbenchManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/WorkbenchManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
checkstyle
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|95 col 5| Block comment has incorrect indentation level 4, expected is 2, indentation should be the same level as line 101.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|101 col 17| Abbreviation in name 'getRemoteURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|103 col 5| 'method def rcurly' has incorrect indentation level 4, expected level should be 2.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|112 col 3| 'CTOR_DEF' should be separated from previous line.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|112 col 25| Abbreviation in name 'provURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|112 col 41| Abbreviation in name 'localURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|112 col 58| Abbreviation in name 'remoteURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|117 col 5| 'ctor def rcurly' has incorrect indentation level 4, expected level should be 2.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|16 col 1| Extra separation in import group before 'javax.swing.JFrame'
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|19 col 1| Extra separation in import group before 'org.apache.jena.rdf.model.Model'
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|23 col 1| Extra separation in import group before 'com.fasterxml.jackson.databind.ObjectMapper'
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|23 col 1| Wrong lexicographical order for 'com.fasterxml.jackson.databind.ObjectMapper' import. Should be before 'org.eclipse.jgit.transport.CredentialItem.Username'.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|33 col 1| Wrong lexicographical order for 'edu.uwb.braingrid.provenance.ProvMgr' import. Should be before 'org.eclipse.jgit.transport.CredentialItem.Username'.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|36 col 1| Wrong lexicographical order for 'edu.uwb.braingrid.workbench.comm.SecureFileTransfer' import. Should be before 'org.eclipse.jgit.transport.CredentialItem.Username'.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|37 col 1| Wrong lexicographical order for 'edu.uwb.braingrid.workbench.model.Simulation' import. Should be before 'org.eclipse.jgit.transport.CredentialItem.Username'.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|38 col 1| Wrong lexicographical order for 'edu.uwb.braingrid.workbench.ui.LoginCredentialsDialog' import. Should be before 'org.eclipse.jgit.transport.CredentialItem.Username'.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|39 col 1| Wrong lexicographical order for 'edu.uwb.braingrid.workbench.ui.SimulationSpecificationDialog' import. Should be before 'org.eclipse.jgit.transport.CredentialItem.Username'.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|155 col 9| 'method def' child has incorrect indentation level 8, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|156 col 5| 'method def rcurly' has incorrect indentation level 4, expected level should be 2.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|199 col 15| Distance between variable 'simName' declaration and its first usage is 5, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|202 col 15| Distance between variable 'username' declaration and its first usage is 5, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|203 col 15| Distance between variable 'password' declaration and its first usage is 5, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|204 col 15| Distance between variable 'fileTransfer' declaration and its first usage is 5, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|210 col 30| Abbreviation in name 'readURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|212 col 22| Abbreviation in name 'provURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|213 col 22| Abbreviation in name 'localURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|214 col 22| Abbreviation in name 'remoteURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|217 col 1| Comment has incorrect indentation level 0, expected is 14, indentation should be the same level as line 218.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/WorkbenchManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/WorkbenchManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/WorkbenchManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/WorkbenchManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/WorkbenchManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
checkstyle
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|370 col 8| 'if' has incorrect indentation level 7, expected level should be 8.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|371 col 10| 'if' child has incorrect indentation level 9, expected level should be 10.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|372 col 10| 'if' child has incorrect indentation level 9, expected level should be 10.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|374 col 10| 'if' has incorrect indentation level 9, expected level should be 10.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|375 col 10| 'if' has incorrect indentation level 9, expected level should be 12.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|376 col 12| 'if' child has incorrect indentation level 11, expected level should be 14.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|377 col 12| 'if' child has incorrect indentation level 11, expected level should be 14.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|378 col 16| 'method call' child has incorrect indentation level 15, expected level should be 16.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|379 col 16| 'method call' child has incorrect indentation level 15, expected level should be 16.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|380 col 16| 'method call' child has incorrect indentation level 15, expected level should be 16.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|381 col 12| 'if' child has incorrect indentation level 11, expected level should be 14.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|382 col 10| 'if rcurly' has incorrect indentation level 9, expected level should be 12.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|383 col 12| 'if' child has incorrect indentation level 11, expected level should be 12.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|386 col 10| 'if rcurly' has incorrect indentation level 9, expected level should be 10.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|387 col 12| 'else' child has incorrect indentation level 11, expected level should be 12.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|390 col 10| 'else rcurly' has incorrect indentation level 9, expected level should be 10.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|391 col 8| 'if rcurly' has incorrect indentation level 7, expected level should be 8.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|393 col 8| 'if' has incorrect indentation level 7, expected level should be 8.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|394 col 10| 'if' child has incorrect indentation level 9, expected level should be 10.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|395 col 10| 'if' child has incorrect indentation level 9, expected level should be 10.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|398 col 10| 'if' child has incorrect indentation level 9, expected level should be 10.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|399 col 10| 'if' child has incorrect indentation level 9, expected level should be 10.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|400 col 8| 'if rcurly' has incorrect indentation level 7, expected level should be 8.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|401 col 6| 'if rcurly' has incorrect indentation level 5, expected level should be 6.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|402 col 8| 'else' child has incorrect indentation level 7, expected level should be 8.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|403 col 6| 'else rcurly' has incorrect indentation level 5, expected level should be 6.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|404 col 4| 'if rcurly' has incorrect indentation level 3, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|405 col 6| 'else' child has incorrect indentation level 5, expected level should be 6.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|406 col 4| 'else rcurly' has incorrect indentation level 3, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|407 col 4| 'method def' child has incorrect indentation level 3, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|409 col 4| 'if' has incorrect indentation level 3, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|410 col 6| 'if' child has incorrect indentation level 5, expected level should be 6.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|411 col 4| 'if rcurly' has incorrect indentation level 3, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|427 col 9| 'method call' child has incorrect indentation level 8, expected level should be 10.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|436 col 5| 'catch' child has incorrect indentation level 4, expected level should be 8.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|437 col 3| 'catch rcurly' has incorrect indentation level 2, expected level should be 6.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|438 col 3| 'if rcurly' has incorrect indentation level 2, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|95 col 5| Block comment has incorrect indentation level 4, expected is 2, indentation should be the same level as line 101.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|101 col 17| Abbreviation in name 'getRemoteURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|103 col 5| 'method def rcurly' has incorrect indentation level 4, expected level should be 2.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|112 col 3| 'CTOR_DEF' should be separated from previous line.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|112 col 25| Abbreviation in name 'provURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|112 col 41| Abbreviation in name 'localURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|112 col 58| Abbreviation in name 'remoteURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|117 col 5| 'ctor def rcurly' has incorrect indentation level 4, expected level should be 2.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|16 col 1| Extra separation in import group before 'javax.swing.JFrame'
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|19 col 1| Extra separation in import group before 'org.apache.jena.rdf.model.Model'
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|23 col 1| Extra separation in import group before 'com.fasterxml.jackson.databind.ObjectMapper'
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|23 col 1| Wrong lexicographical order for 'com.fasterxml.jackson.databind.ObjectMapper' import. Should be before 'org.eclipse.jgit.transport.CredentialItem.Username'.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|33 col 1| Wrong lexicographical order for 'edu.uwb.braingrid.provenance.ProvMgr' import. Should be before 'org.eclipse.jgit.transport.CredentialItem.Username'.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|36 col 1| Wrong lexicographical order for 'edu.uwb.braingrid.workbench.comm.SecureFileTransfer' import. Should be before 'org.eclipse.jgit.transport.CredentialItem.Username'.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|37 col 1| Wrong lexicographical order for 'edu.uwb.braingrid.workbench.model.Simulation' import. Should be before 'org.eclipse.jgit.transport.CredentialItem.Username'.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|38 col 1| Wrong lexicographical order for 'edu.uwb.braingrid.workbench.ui.LoginCredentialsDialog' import. Should be before 'org.eclipse.jgit.transport.CredentialItem.Username'.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|39 col 1| Wrong lexicographical order for 'edu.uwb.braingrid.workbench.ui.SimulationSpecificationDialog' import. Should be before 'org.eclipse.jgit.transport.CredentialItem.Username'.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|155 col 9| 'method def' child has incorrect indentation level 8, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|156 col 5| 'method def rcurly' has incorrect indentation level 4, expected level should be 2.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|199 col 15| Distance between variable 'simName' declaration and its first usage is 5, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|202 col 15| Distance between variable 'username' declaration and its first usage is 5, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|203 col 15| Distance between variable 'password' declaration and its first usage is 5, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|204 col 15| Distance between variable 'fileTransfer' declaration and its first usage is 5, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|210 col 30| Abbreviation in name 'readURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|212 col 22| Abbreviation in name 'provURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|213 col 22| Abbreviation in name 'localURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|214 col 22| Abbreviation in name 'remoteURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|217 col 1| Comment has incorrect indentation level 0, expected is 14, indentation should be the same level as line 218.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
checkstyle
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|402 col 6| 'else rcurly' has incorrect indentation level 5, expected level should be 6.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|403 col 4| 'if rcurly' has incorrect indentation level 3, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|404 col 6| 'else' child has incorrect indentation level 5, expected level should be 6.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|405 col 4| 'else rcurly' has incorrect indentation level 3, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|406 col 4| 'method def' child has incorrect indentation level 3, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|408 col 4| 'if' has incorrect indentation level 3, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|409 col 6| 'if' child has incorrect indentation level 5, expected level should be 6.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|410 col 4| 'if rcurly' has incorrect indentation level 3, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|426 col 9| 'method call' child has incorrect indentation level 8, expected level should be 10.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|435 col 5| 'catch' child has incorrect indentation level 4, expected level should be 8.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|436 col 3| 'catch rcurly' has incorrect indentation level 2, expected level should be 6.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java|437 col 3| 'if rcurly' has incorrect indentation level 2, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|14 col 1| Wrong lexicographical order for 'java.io.InputStreamReader' import. Should be before 'javafx.scene.control.TextArea'.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/comm/SecureFileTransfer.java|360 col 7| 'new' has incorrect indentation level 6, expected level should be 10.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|67 col 5| 'member def modifier' has incorrect indentation level 4, expected level should be 2.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|68 col 5| 'member def modifier' has incorrect indentation level 4, expected level should be 2.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|69 col 5| 'member def modifier' has incorrect indentation level 4, expected level should be 2.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|82 col 7| 'method def' child has incorrect indentation level 6, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|95 col 5| Block comment has incorrect indentation level 4, expected is 2, indentation should be the same level as line 101.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|103 col 5| 'method def rcurly' has incorrect indentation level 4, expected level should be 2.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|112 col 3| 'CTOR_DEF' should be separated from previous line.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|112 col 25| Abbreviation in name 'provURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|112 col 41| Abbreviation in name 'localURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|112 col 58| Abbreviation in name 'remoteURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|117 col 5| 'ctor def rcurly' has incorrect indentation level 4, expected level should be 2.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|145 col 9| 'method def' child has incorrect indentation level 8, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|156 col 9| 'method def' child has incorrect indentation level 8, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|158 col 9| 'method def' child has incorrect indentation level 8, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|168 col 9| 'method def' child has incorrect indentation level 8, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|169 col 9| 'method def' child has incorrect indentation level 8, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|170 col 9| 'method def' child has incorrect indentation level 8, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|171 col 9| 'method def' child has incorrect indentation level 8, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|185 col 17| 'if' child has incorrect indentation level 16, expected level should be 8.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|186 col 17| 'if' child has incorrect indentation level 16, expected level should be 8.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|214 col 5| 'method def modifier' has incorrect indentation level 4, expected level should be 2.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|215 col 9| 'method def' child has incorrect indentation level 8, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|16 col 1| Extra separation in import group before 'javax.swing.JFrame'
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|19 col 1| Extra separation in import group before 'org.apache.jena.rdf.model.Model'
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|23 col 1| Extra separation in import group before 'com.fasterxml.jackson.databind.ObjectMapper'
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|23 col 1| Wrong lexicographical order for 'com.fasterxml.jackson.databind.ObjectMapper' import. Should be before 'org.eclipse.jgit.transport.CredentialItem.Username'.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|33 col 1| Wrong lexicographical order for 'edu.uwb.braingrid.provenance.ProvMgr' import. Should be before 'org.eclipse.jgit.transport.CredentialItem.Username'.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|36 col 1| Wrong lexicographical order for 'edu.uwb.braingrid.workbench.comm.SecureFileTransfer' import. Should be before 'org.eclipse.jgit.transport.CredentialItem.Username'.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|37 col 1| Wrong lexicographical order for 'edu.uwb.braingrid.workbench.model.Simulation' import. Should be before 'org.eclipse.jgit.transport.CredentialItem.Username'.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|38 col 1| Wrong lexicographical order for 'edu.uwb.braingrid.workbench.ui.LoginCredentialsDialog' import. Should be before 'org.eclipse.jgit.transport.CredentialItem.Username'.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|39 col 1| Wrong lexicographical order for 'edu.uwb.braingrid.workbench.ui.SimulationSpecificationDialog' import. Should be before 'org.eclipse.jgit.transport.CredentialItem.Username'.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|155 col 9| 'method def' child has incorrect indentation level 8, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|156 col 5| 'method def rcurly' has incorrect indentation level 4, expected level should be 2.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|199 col 15| Distance between variable 'simName' declaration and its first usage is 5, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|202 col 15| Distance between variable 'username' declaration and its first usage is 5, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|203 col 15| Distance between variable 'password' declaration and its first usage is 5, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|204 col 15| Distance between variable 'fileTransfer' declaration and its first usage is 5, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|210 col 30| Abbreviation in name 'readURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|212 col 22| Abbreviation in name 'provURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|213 col 22| Abbreviation in name 'localURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|214 col 22| Abbreviation in name 'remoteURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|217 col 1| Comment has incorrect indentation level 0, expected is 14, indentation should be the same level as line 218.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/WorkbenchManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/WorkbenchManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
checkstyle
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|112 col 25| Abbreviation in name 'provURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|112 col 41| Abbreviation in name 'localURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|112 col 58| Abbreviation in name 'remoteURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|117 col 5| 'ctor def rcurly' has incorrect indentation level 4, expected level should be 2.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|145 col 9| 'method def' child has incorrect indentation level 8, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|156 col 9| 'method def' child has incorrect indentation level 8, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|158 col 9| 'method def' child has incorrect indentation level 8, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|168 col 9| 'method def' child has incorrect indentation level 8, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|169 col 9| 'method def' child has incorrect indentation level 8, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|170 col 9| 'method def' child has incorrect indentation level 8, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|171 col 9| 'method def' child has incorrect indentation level 8, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|185 col 17| 'if' child has incorrect indentation level 16, expected level should be 8.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|186 col 17| 'if' child has incorrect indentation level 16, expected level should be 8.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|214 col 5| 'method def modifier' has incorrect indentation level 4, expected level should be 2.
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java|215 col 9| 'method def' child has incorrect indentation level 8, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|16 col 1| Extra separation in import group before 'javax.swing.JFrame'
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|19 col 1| Extra separation in import group before 'org.apache.jena.rdf.model.Model'
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|23 col 1| Extra separation in import group before 'com.fasterxml.jackson.databind.ObjectMapper'
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|23 col 1| Wrong lexicographical order for 'com.fasterxml.jackson.databind.ObjectMapper' import. Should be before 'org.eclipse.jgit.transport.CredentialItem.Username'.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|33 col 1| Wrong lexicographical order for 'edu.uwb.braingrid.provenance.ProvMgr' import. Should be before 'org.eclipse.jgit.transport.CredentialItem.Username'.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|36 col 1| Wrong lexicographical order for 'edu.uwb.braingrid.workbench.comm.SecureFileTransfer' import. Should be before 'org.eclipse.jgit.transport.CredentialItem.Username'.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|37 col 1| Wrong lexicographical order for 'edu.uwb.braingrid.workbench.model.Simulation' import. Should be before 'org.eclipse.jgit.transport.CredentialItem.Username'.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|38 col 1| Wrong lexicographical order for 'edu.uwb.braingrid.workbench.ui.LoginCredentialsDialog' import. Should be before 'org.eclipse.jgit.transport.CredentialItem.Username'.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|39 col 1| Wrong lexicographical order for 'edu.uwb.braingrid.workbench.ui.SimulationSpecificationDialog' import. Should be before 'org.eclipse.jgit.transport.CredentialItem.Username'.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|155 col 9| 'method def' child has incorrect indentation level 8, expected level should be 4.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|156 col 5| 'method def rcurly' has incorrect indentation level 4, expected level should be 2.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|199 col 15| Distance between variable 'simName' declaration and its first usage is 5, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|202 col 15| Distance between variable 'username' declaration and its first usage is 5, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|203 col 15| Distance between variable 'password' declaration and its first usage is 5, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|204 col 15| Distance between variable 'fileTransfer' declaration and its first usage is 5, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|210 col 30| Abbreviation in name 'readURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|212 col 22| Abbreviation in name 'provURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|213 col 22| Abbreviation in name 'localURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|214 col 22| Abbreviation in name 'remoteURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|217 col 1| Comment has incorrect indentation level 0, expected is 14, indentation should be the same level as line 218.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
checkstyle
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|202 col 15| Distance between variable 'username' declaration and its first usage is 5, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|203 col 15| Distance between variable 'password' declaration and its first usage is 5, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|204 col 15| Distance between variable 'fileTransfer' declaration and its first usage is 5, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|210 col 30| Abbreviation in name 'readURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|212 col 22| Abbreviation in name 'provURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|213 col 22| Abbreviation in name 'localURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|214 col 22| Abbreviation in name 'remoteURI' must contain no more than '1' consecutive capital letters.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java|217 col 1| Comment has incorrect indentation level 0, expected is 14, indentation should be the same level as line 218.
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/provenance/ProvMgr.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbench/script/ScriptManager.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java
Outdated
Show resolved
Hide resolved
WorkbenchProject/src/main/java/edu/uwb/braingrid/workbenchdashboard/WorkbenchDashboard.java
Outdated
Show resolved
Hide resolved
|
This should be the final version of this branch. However please note that this branch does not function properly until I merge the Graphitti logger for Workbench. But once that's done, this should work properly. I will make a few more tests after merging the Graphitti logger |
This branch adds the feature for resume the last simulation. It will save necessary data when the script is run. If the user quit workbench halfway, the next time it opens it, it will check if the simulation is complete, if it is, it will download corresponding results.
There are some minor bugs, and likely to have some checkstyle issues which I will fix later. I will also recheck the changes to delete some of the unused codes and do a little refactoring.
Another feature to add is to make it remember multiple simulations instead of just one. And let the user to decide which one to resume