feat: Add expression registry to native planner #2851
+839
−209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2851 +/- ##
============================================
+ Coverage 56.12% 59.14% +3.01%
- Complexity 976 1471 +495
============================================
Files 119 167 +48
Lines 11743 15235 +3492
Branches 2251 2513 +262
============================================
+ Hits 6591 9010 +2419
- Misses 4012 4942 +930
- Partials 1140 1283 +143 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andygrove
changed the title
andygrove
commented
Dec 5, 2025
Comment on lines
+248
to
+251
| // Try to use the modular registry first - this automatically handles any registered expression types | ||
| if ExpressionRegistry::global().can_handle(spark_expr) { | ||
| return ExpressionRegistry::global().create_expr(spark_expr, input_schema, self); | ||
| } |
Member
Author
There was a problem hiding this comment.
This is the main change in the planner
Contributor
Contributor
|
Should we update the developer guide as part of this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Similar to the effort of creating the serde framework in Scala, this PR starts a similar process for the native planning code. We currently have >4k LOC in
planner.rsfor handling all supported operations and expressions and this PR introduces a framework to allow us to start moving code into separate files.What changes are included in this PR?
ExpressionRegistryExpressionTypeenum andExpressionBuildertraitHow are these changes tested?