Removed unnecessary pagehandle

Author: monadoid

packages/core/lib/v3/types/public/page.ts

@@ -1,27 +1,11 @@
-import { z } from "zod";
-import { Page } from "../../understudy/page";
-import { Page as PlaywrightPage } from "playwright-core";
 import { Page as PatchrightPage } from "patchright-core";
+import { Page as PlaywrightPage } from "playwright-core";
 import { Page as PuppeteerPage } from "puppeteer-core";
+import { Page } from "../../understudy/page";
 
 export type { PlaywrightPage, PatchrightPage, PuppeteerPage, Page };
 
-export const pageHandleSchema = z.object({
-  pageId: z.string().min(1),
-  targetId: z.string().min(1),
-});
-
-export interface PageHandle {
-  pageId: string;
-  targetId: string;
-}
-
-export type AnyPage =
-  | PlaywrightPage
-  | PuppeteerPage
-  | PatchrightPage
-  | Page
-  | PageHandle;
+export type AnyPage = PlaywrightPage | PuppeteerPage | PatchrightPage | Page;
 
 export { ConsoleMessage } from "../../understudy/consoleMessage";
 export type { ConsoleListener } from "../../understudy/consoleMessage";

packages/core/lib/v3/v3.ts

@@ -56,7 +56,6 @@ import {
   LocalBrowserLaunchOptions,
   V3Options,
   AnyPage,
-  PageHandle,
   PatchrightPage,
   PlaywrightPage,
   PuppeteerPage,
@@ -1390,15 +1389,6 @@ export class V3 {
     );
   }
 
-  private hasTargetId(p: unknown): p is PageHandle {
-    return (
-      typeof p === "object" &&
-      p !== null &&
-      typeof (p as PageHandle).pageId === "string" &&
-      typeof (p as PageHandle).targetId === "string"
-    );
-  }
-
   private isPlaywrightPage(p: unknown): p is PlaywrightPage {
     return (
       typeof p === "object" &&
@@ -1423,20 +1413,6 @@ export class V3 {
     );
   }
 
-  private resolvePageFromHandle(handle: PageHandle): Page {
-    const ctx = this.ctx;
-    if (!ctx) {
-      throw new StagehandNotInitializedError("resolvePage()");
-    }
-    const page = ctx.resolvePageByTargetId(handle.targetId);
-    if (!page) {
-      throw new StagehandInitError(
-        `Failed to resolve V3 Page from handle targetId=${handle.targetId}.`,
-      );
-    }
-    return page;
-  }
-
   /** Resolve an external page reference or fall back to the active V3 page. */
   private async resolvePage(page?: AnyPage): Promise<Page> {
     if (page) {
@@ -1450,9 +1426,6 @@ export class V3 {
   }
 
   private async normalizeToV3Page(input: AnyPage): Promise<Page> {
-    if (this.hasTargetId(input)) {
-      return this.resolvePageFromHandle(input);
-    }
     if (input instanceof (await import("./understudy/page")).Page) {
       return input as Page;
     }

packages/core/tests/page-boundary.test.ts

@@ -83,23 +83,6 @@ function stubAgentCache(instance: Stagehand): void {
   });
 }
 
-function installHandleContext(
-  instance: Stagehand,
-  targetId: string,
-  page: Page,
-) {
-  const resolvePageByTargetId = vi
-    .fn()
-    .mockImplementation((requestedTargetId: string) => {
-      if (requestedTargetId === targetId) {
-        return page;
-      }
-      return undefined;
-    });
-  Reflect.set(instance, "ctx", { resolvePageByTargetId });
-  return resolvePageByTargetId;
-}
-
 function createApiClient() {
   return {
     act: vi.fn().mockResolvedValue(defaultActResult),
@@ -143,29 +126,6 @@ describe("Page boundary contracts", () => {
         resolvePage.call(stagehand, {} as AnyPage),
       ).rejects.toBeInstanceOf(StagehandInvalidArgumentError);
     });
-
-    it("maps PageHandle.targetId back to a V3 Page", async () => {
-      const stagehand = createStagehand();
-      const fakePage = createInternalPage("frame-handle");
-      const resolvePageByTargetId = installHandleContext(
-        stagehand,
-        "target-handle",
-        fakePage,
-      );
-
-      const resolvePage = Reflect.get(stagehand, "resolvePage") as (
-        page?: AnyPage,
-      ) => Promise<Page>;
-
-      const handle = {
-        pageId: "page-handle",
-        targetId: "target-handle",
-      } as AnyPage;
-      const resolved = await resolvePage.call(stagehand, handle);
-
-      expect(resolvePageByTargetId).toHaveBeenCalledWith("target-handle");
-      expect(resolved).toBe(fakePage);
-    });
   });
 
   describe("normalizeToV3Page", () => {
@@ -263,16 +223,17 @@ describe("Page boundary contracts", () => {
       stubAgentCache(stagehand);
 
       const frameId = "frame-act";
-      const targetId = "target-act";
       const fakePage = createInternalPage(frameId);
-      installHandleContext(stagehand, targetId, fakePage);
+      Reflect.set(
+        stagehand,
+        "resolvePage",
+        vi.fn().mockResolvedValue(fakePage),
+      );
 
       const apiClient = createApiClient();
       Reflect.set(stagehand, "apiClient", apiClient);
 
-      const options = {
-        page: { pageId: "page-act", targetId } as AnyPage,
-      };
+      const options = {};
 
       await stagehand.act("Click button", options);
 
@@ -289,17 +250,18 @@ describe("Page boundary contracts", () => {
       stubAgentCache(stagehand);
 
       const frameId = "frame-extract";
-      const targetId = "target-extract";
       const fakePage = createInternalPage(frameId);
-      installHandleContext(stagehand, targetId, fakePage);
+      Reflect.set(
+        stagehand,
+        "resolvePage",
+        vi.fn().mockResolvedValue(fakePage),
+      );
 
       const apiClient = createApiClient();
       Reflect.set(stagehand, "apiClient", apiClient);
 
       const schema = z.object({ value: z.string() });
-      const options = {
-        page: { pageId: "page-extract", targetId } as AnyPage,
-      };
+      const options = {};
 
       await stagehand.extract("Summarize", schema, options);
 
@@ -317,16 +279,17 @@ describe("Page boundary contracts", () => {
       stubAgentCache(stagehand);
 
       const frameId = "frame-observe";
-      const targetId = "target-observe";
       const fakePage = createInternalPage(frameId);
-      installHandleContext(stagehand, targetId, fakePage);
+      Reflect.set(
+        stagehand,
+        "resolvePage",
+        vi.fn().mockResolvedValue(fakePage),
+      );
 
       const apiClient = createApiClient();
       Reflect.set(stagehand, "apiClient", apiClient);
 
-      const options = {
-        page: { pageId: "page-observe", targetId } as AnyPage,
-      };
+      const options = {};
 
       await stagehand.observe("Check", options);
 

packages/core/tests/public-api/public-types.test.ts

@@ -91,8 +91,7 @@ describe("Stagehand public API types", () => {
       | Stagehand.PlaywrightPage
       | Stagehand.PuppeteerPage
       | Stagehand.PatchrightPage
-      | Stagehand.Page
-      | Stagehand.PageHandle;
+      | Stagehand.Page;
 
     it("matches expected type shape", () => {
       expectTypeOf<Stagehand.AnyPage>().toEqualTypeOf<ExpectedAnyPage>();

packages/sdk/src/constants.ts

@@ -48,7 +48,10 @@ export const pageTextSchema = createSchemaStub({
 });
 
 export function getZodType(schema: StagehandZodSchema): string {
-  return (schema as unknown as { _def?: { typeName?: string } })?._def?.typeName ?? "unknown";
+  return (
+    (schema as unknown as { _def?: { typeName?: string } })?._def?.typeName ??
+    "unknown"
+  );
 }
 
 export function transformSchema(

packages/sdk/src/runtime.ts

@@ -37,7 +37,8 @@ import type {
   ChatCompletionOptions,
   CreateChatCompletionOptions,
   LLMResponse,
-  LLMUsage, AgentClient,
+  LLMUsage,
+  AgentClient,
 } from "./types";
 import {
   AnnotatedScreenshotText,
@@ -276,7 +277,10 @@ export class V3Evaluator {
   }
 
   batchAsk(
-    _instructions: Array<{ instruction: string; options?: Record<string, unknown> }>,
+    _instructions: Array<{
+      instruction: string;
+      options?: Record<string, unknown>;
+    }>,
   ): Promise<unknown> {
     return rejectNotImplemented("V3Evaluator.batchAsk");
   }
@@ -287,11 +291,7 @@ export class V3Evaluator {
 }
 
 export async function connectToMCPServer(
-  _serverConfig:
-    | string
-    | URL
-    | StdioServerConfig
-    | ConnectToMCPServerOptions,
+  _serverConfig: string | URL | StdioServerConfig | ConnectToMCPServerOptions,
 ): Promise<MCPClient> {
   return rejectNotImplemented<MCPClient>("connectToMCPServer");
 }

packages/sdk/src/types.ts

@@ -243,13 +243,7 @@ export interface V3Options {
   browserbaseSessionCreateParams?: Record<string, unknown>;
 }
 
-export interface PageHandle {
-  targetId?: string;
-  sessionId?: string;
-}
-
 export type AnyPage =
-  | PageHandle
   | {
       kind?: string;
       reference?: unknown;

tests/shared/exportSurfaceSuite.ts

@@ -1,10 +1,7 @@
 import { describe, expect, it } from "vitest";
 import { buildPublicApiShape } from "./publicApiManifest";
 
-export function runExportSurfaceSuite<
-  M extends Record<string, unknown>,
-  D,
->(
+export function runExportSurfaceSuite<M extends Record<string, unknown>, D>(
   label: string,
   moduleExports: M,
   defaultExport: D,
@@ -13,9 +10,7 @@ export function runExportSurfaceSuite<
     const publicApiShape = buildPublicApiShape(moduleExports, defaultExport);
 
     type PublicAPI = {
-      [K in keyof typeof publicApiShape]: K extends "default"
-        ? D
-        : M[K];
+      [K in keyof typeof publicApiShape]: K extends "default" ? D : M[K];
     };
 
     it("public API shape matches module exports", () => {

tests/shared/publicApiManifest.ts

@@ -36,9 +36,10 @@ export const PUBLIC_API_EXPORT_KEYS = [
 export type PublicApiExportKey = (typeof PUBLIC_API_EXPORT_KEYS)[number];
 
 export type PublicApiShape<M extends Record<string, unknown>, D> = {
-  [K in PublicApiExportKey | PublicErrorTypeKey | "default"]: K extends "default"
-    ? D
-    : M[K];
+  [K in
+    | PublicApiExportKey
+    | PublicErrorTypeKey
+    | "default"]: K extends "default" ? D : M[K];
 };
 
 export function buildPublicApiShape<M extends Record<string, unknown>, D>(