Skip to content

Allowed specifying hex strings in the Postgres escape format #3756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
egormanga wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allowed specifying hex strings in the Postgres escape format #3756

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/lib/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ pub fn from_hex_pad<R: hex::FromHex<Error = hex::FromHexError>, T: AsRef<[u8]>>(
hex: T,
) -> Result<R, hex::FromHexError> {
let hex = hex.as_ref();
let hex = if hex.starts_with(b"0x") {
let hex = if hex.starts_with(b"0x") || hex.starts_with(b"\\x") {
Copy link
Collaborator

@joshua-spacetime joshua-spacetime Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check needs to be in its own branch to account for enclosing delimiters.

Copy link
Contributor Author

@egormanga egormanga Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are those? The escaped literal goes: \xAABBCCDD, with no tail.

&hex[2..]
} else if hex.starts_with(b"X'") {
&hex[2..hex.len()]
Expand Down