feat: replace static check icon with Rive animation #3348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 1 files ±0 1 suites ±0 9m 49s ⏱️ +21s For more details on these errors, see this check. Results for commit 5129794. ± Comparison against base commit 1eca78e. ♻️ This comment has been updated with latest results. |
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
rohitpaulk
force-pushed
the
pk-branch-11
branch
from
ef8aa76 to
798dd75
Compare
Bundle ReportChanges will decrease total bundle size by 1.5kB (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: client-array-pushAssets Changed:
|
rohitpaulk
force-pushed
the
pk-branch-11
branch
3 times, most recently
from
85bdb47 to
bf66b08
Compare
Update start-workflow-tutorial-screen to use an animated checkmark via Rive instead of the static SVG icon. This improves visual feedback and enhances user experience on the workflow completion modal. feat(ui): replace exclamation SVG with Rive warning animation Update the previous steps incomplete modal to use a Rive animation instead of a static SVG icon for the warning indicator. This change enhances the visual feedback by providing a more engaging and dynamic animation, improving user experience and drawing attention more effectively to incomplete course steps. fix(ui): increase checkmark icon size in tutorial screen Increase the checkmark icon size from 48x48px to 64x64px in the StartWorkflowTutorialScreen to improve visibility and user feedback during the course setup process.
Update the choose-action-step component to use a Rive animation for the checkmark icon instead of a static SVG. This enhances visual feedback by adding smooth, scalable animations, improving user experience in the tests passed modal.
rohitpaulk
force-pushed
the
pk-branch-11
branch
from
bf66b08 to
5129794
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update start-workflow-tutorial-screen to use an animated checkmark
via Rive instead of the static SVG icon. This improves visual feedback
and enhances user experience on the workflow completion modal.
Note
Swap static SVG status icons for Rive animations in two course-page modals.
app/components/course-page/course-stage-step/tests-passed-modal/choose-action-step.hbs: useRiveAnimationwithcheckmark_icon.rivinstead ofsvg-jar "check-circle".app/components/course-page/previous-steps-incomplete-modal.hbs: useRiveAnimationwithwarning_icon.rivinstead ofsvg-jar "exclamation".Written by Cursor Bugbot for commit 5129794. This will update automatically on new commits. Configure here.