-
Notifications
You must be signed in to change notification settings - Fork 334
Remove project-manager #14406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Remove project-manager #14406
Conversation
|
My hope is, that only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Make it green and integrate.
- one failing LibrariesTest:
- should download the library sending progress notifications and correctly place it in cache *** FAILED *** (1 second, 725 milliseconds)
The Option on which value was invoked was not defined. (LibrariesTest.scala:624)
# Conflicts: # build.sbt
hubertp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove project-manager from the list of aggregates
...ne/language-server/src/test/scala/org/enso/languageserver/websocket/json/LibrariesTest.scala
Outdated
Show resolved
Hide resolved
de055b6 to
006c5d3
Compare
|
I could not figure out what was going on in the faling LibrariesTest. I have tried to add various verbose output to the simple library server and co. For now, I have decided to ignore that test in 3126b0f and will be re-enabled in subsequent PRs. This PR should be merged ASAP, since it is very big with high probability of creating conflicts. |
I am not sure about the LibrariesTest being commented out.
Continuation of #14174.
Part of #14308.
Pull Request Description
Removes sources of
project-manager:sbtproject-manager.project-managersbt project is minimized - now the configuration has just cca 30 lines of code.So now:
project-manager/testis a no-opbuildProjectManagerDistributionbuilds native image from just a single Java source with an emptymainmethod.As opposed to the first attempt to remove
project-managerin #14174, does only minimal changes. This PR does not remove project-manager, instead, it minimalizes project-manager.Important Notes
Will apply rest of the changes from #14174 in subsequent PRs.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.