Skip to content

Conversation

@Akirathan
Copy link
Member

@Akirathan Akirathan commented Nov 28, 2025

Continuation of #14174.

Part of #14308.

Pull Request Description

Removes sources of project-manager:

  • Does not remove the project from sbt
  • Does not touch any other build tool (rust build script / GH workflow) configuration.
  • Leaves in only a dummy single Java source in the project-manager.
    • So that all the other commands that are still used on the CI continue to work.
  • project-manager sbt project is minimized - now the configuration has just cca 30 lines of code.

So now:

  • project-manager/test is a no-op
  • buildProjectManagerDistribution builds native image from just a single Java source with an empty main method.

As opposed to the first attempt to remove project-manager in #14174, does only minimal changes. This PR does not remove project-manager, instead, it minimalizes project-manager.

Important Notes

Will apply rest of the changes from #14174 in subsequent PRs.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@Akirathan Akirathan self-assigned this Nov 28, 2025
@Akirathan Akirathan added CI: No changelog needed Do not require a changelog entry for this PR. CI: Clean build required CI runners will be cleaned before and after this PR is built. labels Nov 28, 2025
@Akirathan Akirathan requested a review from vitvakatu November 28, 2025 19:33
@Akirathan
Copy link
Member Author

My hope is, that only Verify License Packages job will fail. If that will be the case, I will fix that job on Monday and we can integrate this later next week.

JaroslavTulach
JaroslavTulach previously approved these changes Nov 29, 2025
Copy link
Member

@JaroslavTulach JaroslavTulach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- should download the library sending progress notifications and correctly place it in cache *** FAILED *** (1 second, 725 milliseconds)
   The Option on which value was invoked was not defined. (LibrariesTest.scala:624)

@Akirathan Akirathan linked an issue Dec 1, 2025 that may be closed by this pull request
Copy link
Collaborator

@hubertp hubertp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove project-manager from the list of aggregates

@Akirathan Akirathan force-pushed the wip/akirathan/remove-project-manager branch from de055b6 to 006c5d3 Compare December 1, 2025 16:07
@Akirathan
Copy link
Member Author

I could not figure out what was going on in the faling LibrariesTest. I have tried to add various verbose output to the simple library server and co. For now, I have decided to ignore that test in 3126b0f and will be re-enabled in subsequent PRs. This PR should be merged ASAP, since it is very big with high probability of creating conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: No changelog needed Do not require a changelog entry for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove project-manager references in engine

5 participants