Remove feature flag cxxNativeAnimatedRemoveJsSync (#54740)

Summary:
Pull Request resolved: #54740

## Changelog:

[Internal] [Changed] - Remove feature flag cxxNativeAnimatedRemoveJsSync

It's always rolled out with cxx animated and we haven't found new issues with it

Reviewed By: lenaic

Differential Revision: D88082232

fbshipit-source-id: 3b9f29c20a7f41cd1d826257a9e2c42c11fcee0f

Author: zeyap

packages/react-native/Libraries/Animated/__tests__/Animated-itest.js

@@ -4,7 +4,6 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @fantom_flags cxxNativeAnimatedRemoveJsSync:*
  * @flow strict-local
  * @format
  */
@@ -18,7 +17,6 @@ import * as Fantom from '@react-native/fantom';
 import {createRef} from 'react';
 import {Animated, View, useAnimatedValue} from 'react-native';
 import {allowStyleProp} from 'react-native/Libraries/Animated/NativeAnimatedAllowlist';
-import * as ReactNativeFeatureFlags from 'react-native/src/private/featureflags/ReactNativeFeatureFlags';
 import ReactNativeElement from 'react-native/src/private/webapis/dom/nodes/ReactNativeElement';
 
 test('moving box by 100 points', () => {
@@ -76,14 +74,9 @@ test('moving box by 100 points', () => {
   Fantom.unstable_produceFramesForDuration(500);
 
   // Animation is completed now. C++ Animated will commit the final position to the shadow tree.
-  if (ReactNativeFeatureFlags.cxxNativeAnimatedRemoveJsSync()) {
-    // TODO(T232605345): this shouldn't be neccessary once we fix Android's race condition.
-    Fantom.runWorkLoop();
-    expect(viewElement.getBoundingClientRect().x).toBe(100);
-  } else {
-    Fantom.runWorkLoop(); // Animated still schedules a React state update for synchronisation to shadow tree
-    expect(viewElement.getBoundingClientRect().x).toBe(100);
-  }
+  // TODO(T232605345): this shouldn't be neccessary once we fix Android's race condition.
+  Fantom.runWorkLoop();
+  expect(viewElement.getBoundingClientRect().x).toBe(100);
 });
 
 test('animation driven by onScroll event', () => {
@@ -334,21 +327,11 @@ test('moving box by 50 points with offset 10', () => {
       .translateX,
   ).toBeCloseTo(60, 0.001);
 
-  if (ReactNativeFeatureFlags.cxxNativeAnimatedRemoveJsSync()) {
-    // TODO(T232605345): The following line won't be necessary once race condition on Android is fixed.
-    Fantom.runWorkLoop();
-    expect(root.getRenderedOutput({props: ['transform']}).toJSX()).toEqual(
-      <rn-view transform='[{"translateX": 60.000000}]' />,
-    );
-  } else {
-    expect(root.getRenderedOutput({props: ['transform']}).toJSX()).toEqual(
-      <rn-view transform="[]" />,
-    );
-    Fantom.runWorkLoop(); // Animated still schedules a React state update for synchronisation to shadow tree
-    expect(root.getRenderedOutput({props: ['transform']}).toJSX()).toEqual(
-      <rn-view transform='[{"translateX": 60.000000}]' />, // // must include offset.
-    );
-  }
+  // TODO(T232605345): The following line won't be necessary once race condition on Android is fixed.
+  Fantom.runWorkLoop();
+  expect(root.getRenderedOutput({props: ['transform']}).toJSX()).toEqual(
+    <rn-view transform='[{"translateX": 60.000000}]' />,
+  );
 
   expect(finishValue?.finished).toBe(true);
   expect(finishValue?.value).toBe(50); // must not include offset.
@@ -734,16 +717,10 @@ test('Animated.sequence', () => {
     Fantom.unstable_getDirectManipulationProps(element).transform[0].translateY,
   ).toBeCloseTo(0, 0.001);
 
-  if (ReactNativeFeatureFlags.cxxNativeAnimatedRemoveJsSync()) {
-    // TODO(T232605345): The following two lines won't be necessary once race condition on Android is fixed
-    expect(element.getBoundingClientRect().y).toBe(-16);
-    Fantom.runWorkLoop();
-    expect(element.getBoundingClientRect().y).toBe(0);
-  } else {
-    expect(element.getBoundingClientRect().y).toBe(-16);
-    Fantom.runWorkLoop(); // React update to sync end state of 2nd timing animation in sequence
-    expect(element.getBoundingClientRect().y).toBe(0);
-  }
+  // TODO(T232605345): The following two lines won't be necessary once race condition on Android is fixed
+  expect(element.getBoundingClientRect().y).toBe(-16);
+  Fantom.runWorkLoop();
+  expect(element.getBoundingClientRect().y).toBe(0);
 
   expect(_isSequenceFinished).toBe(true);
 });

packages/react-native/Libraries/Animated/__tests__/AnimatedBackend-itest.js

@@ -69,6 +69,16 @@ test('animated opacity', () => {
     _opacityAnimation?.stop();
   });
 
+  // TODO: T246961305 rendered output should be <rn-view opacity="0" /> at this point
+  expect(root.getRenderedOutput({props: ['opacity']}).toJSX()).toEqual(
+    <rn-view />,
+  );
+
+  // Re-render
+  Fantom.runTask(() => {
+    root.render(<MyApp />);
+  });
+
   expect(root.getRenderedOutput({props: ['opacity']}).toJSX()).toEqual(
     <rn-view opacity="0" />,
   );

packages/react-native/Libraries/Animated/animations/Animation.js

@@ -151,8 +151,7 @@ export default class Animation {
             animatedValue.__onAnimatedValueUpdateReceived(value, offset);
 
             const isJsSyncRemoved =
-              ReactNativeFeatureFlags.cxxNativeAnimatedEnabled() &&
-              ReactNativeFeatureFlags.cxxNativeAnimatedRemoveJsSync();
+              ReactNativeFeatureFlags.cxxNativeAnimatedEnabled();
             if (!isJsSyncRemoved) {
               if (this.__isLooping === true) {
                 return;

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlags.kt

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<2e69f1b64e18567abff05a1f8bc7014d>>
+ * @generated SignedSource<<5685f79f9b08afe94f5b3e8ec8ff6748>>
  */
 
 /**
@@ -48,12 +48,6 @@ public object ReactNativeFeatureFlags {
   @JvmStatic
   public fun cxxNativeAnimatedEnabled(): Boolean = accessor.cxxNativeAnimatedEnabled()
 
-  /**
-   * Removes JS sync at end of native animation
-   */
-  @JvmStatic
-  public fun cxxNativeAnimatedRemoveJsSync(): Boolean = accessor.cxxNativeAnimatedRemoveJsSync()
-
   /**
    * Dispatch view commands in mount item order.
    */

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsCxxAccessor.kt

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<82bc3d80b3f36ee448ede8f69ba90248>>
+ * @generated SignedSource<<6645323047d21e58469de0d385954eab>>
  */
 
 /**
@@ -23,7 +23,6 @@ internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAcces
   private var commonTestFlagCache: Boolean? = null
   private var cdpInteractionMetricsEnabledCache: Boolean? = null
   private var cxxNativeAnimatedEnabledCache: Boolean? = null
-  private var cxxNativeAnimatedRemoveJsSyncCache: Boolean? = null
   private var disableEarlyViewCommandExecutionCache: Boolean? = null
   private var disableImageViewPreallocationAndroidCache: Boolean? = null
   private var disableMountItemReorderingAndroidCache: Boolean? = null
@@ -138,15 +137,6 @@ internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAcces
     return cached
   }
 
-  override fun cxxNativeAnimatedRemoveJsSync(): Boolean {
-    var cached = cxxNativeAnimatedRemoveJsSyncCache
-    if (cached == null) {
-      cached = ReactNativeFeatureFlagsCxxInterop.cxxNativeAnimatedRemoveJsSync()
-      cxxNativeAnimatedRemoveJsSyncCache = cached
-    }
-    return cached
-  }
-
   override fun disableEarlyViewCommandExecution(): Boolean {
     var cached = disableEarlyViewCommandExecutionCache
     if (cached == null) {

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsCxxInterop.kt

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<c94da1f2b880dbcbd02b2ccc1da0c387>>
+ * @generated SignedSource<<3da42d9ffdbba52e9e1d11a4e4dac8c4>>
  */
 
 /**
@@ -34,8 +34,6 @@ public object ReactNativeFeatureFlagsCxxInterop {
 
   @DoNotStrip @JvmStatic public external fun cxxNativeAnimatedEnabled(): Boolean
 
-  @DoNotStrip @JvmStatic public external fun cxxNativeAnimatedRemoveJsSync(): Boolean
-
   @DoNotStrip @JvmStatic public external fun disableEarlyViewCommandExecution(): Boolean
 
   @DoNotStrip @JvmStatic public external fun disableImageViewPreallocationAndroid(): Boolean

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<a5795c5441af8d4e4151e4c89304fb2f>>
+ * @generated SignedSource<<46e1f708d91d5ec45c866b8192192e72>>
  */
 
 /**
@@ -29,8 +29,6 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi
 
   override fun cxxNativeAnimatedEnabled(): Boolean = false
 
-  override fun cxxNativeAnimatedRemoveJsSync(): Boolean = false
-
   override fun disableEarlyViewCommandExecution(): Boolean = false
 
   override fun disableImageViewPreallocationAndroid(): Boolean = false

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsLocalAccessor.kt

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<ceaebd9c6453b8d6a44e5d45343e0ba4>>
+ * @generated SignedSource<<c19ea5e9ad6435b1f8587287cacf020b>>
  */
 
 /**
@@ -27,7 +27,6 @@ internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcc
   private var commonTestFlagCache: Boolean? = null
   private var cdpInteractionMetricsEnabledCache: Boolean? = null
   private var cxxNativeAnimatedEnabledCache: Boolean? = null
-  private var cxxNativeAnimatedRemoveJsSyncCache: Boolean? = null
   private var disableEarlyViewCommandExecutionCache: Boolean? = null
   private var disableImageViewPreallocationAndroidCache: Boolean? = null
   private var disableMountItemReorderingAndroidCache: Boolean? = null
@@ -145,16 +144,6 @@ internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcc
     return cached
   }
 
-  override fun cxxNativeAnimatedRemoveJsSync(): Boolean {
-    var cached = cxxNativeAnimatedRemoveJsSyncCache
-    if (cached == null) {
-      cached = currentProvider.cxxNativeAnimatedRemoveJsSync()
-      accessedFeatureFlags.add("cxxNativeAnimatedRemoveJsSync")
-      cxxNativeAnimatedRemoveJsSyncCache = cached
-    }
-    return cached
-  }
-
   override fun disableEarlyViewCommandExecution(): Boolean {
     var cached = disableEarlyViewCommandExecutionCache
     if (cached == null) {

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsProvider.kt

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<91441ffa16383203cf8ef82e1edf4451>>
+ * @generated SignedSource<<17400be6ee20befd9eafb094455dfb63>>
  */
 
 /**
@@ -29,8 +29,6 @@ public interface ReactNativeFeatureFlagsProvider {
 
   @DoNotStrip public fun cxxNativeAnimatedEnabled(): Boolean
 
-  @DoNotStrip public fun cxxNativeAnimatedRemoveJsSync(): Boolean
-
   @DoNotStrip public fun disableEarlyViewCommandExecution(): Boolean
 
   @DoNotStrip public fun disableImageViewPreallocationAndroid(): Boolean

packages/react-native/ReactAndroid/src/main/jni/react/featureflags/JReactNativeFeatureFlagsCxxInterop.cpp

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<95616bb241e59e35a9f4b3667cbc0822>>
+ * @generated SignedSource<<66f2c701d95db2fbeefb2705ae326e08>>
  */
 
 /**
@@ -57,12 +57,6 @@ class ReactNativeFeatureFlagsJavaProvider
     return method(javaProvider_);
   }
 
-  bool cxxNativeAnimatedRemoveJsSync() override {
-    static const auto method =
-        getReactNativeFeatureFlagsProviderJavaClass()->getMethod<jboolean()>("cxxNativeAnimatedRemoveJsSync");
-    return method(javaProvider_);
-  }
-
   bool disableEarlyViewCommandExecution() override {
     static const auto method =
         getReactNativeFeatureFlagsProviderJavaClass()->getMethod<jboolean()>("disableEarlyViewCommandExecution");
@@ -598,11 +592,6 @@ bool JReactNativeFeatureFlagsCxxInterop::cxxNativeAnimatedEnabled(
   return ReactNativeFeatureFlags::cxxNativeAnimatedEnabled();
 }
 
-bool JReactNativeFeatureFlagsCxxInterop::cxxNativeAnimatedRemoveJsSync(
-    facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/) {
-  return ReactNativeFeatureFlags::cxxNativeAnimatedRemoveJsSync();
-}
-
 bool JReactNativeFeatureFlagsCxxInterop::disableEarlyViewCommandExecution(
     facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/) {
   return ReactNativeFeatureFlags::disableEarlyViewCommandExecution();
@@ -1073,9 +1062,6 @@ void JReactNativeFeatureFlagsCxxInterop::registerNatives() {
       makeNativeMethod(
         "cxxNativeAnimatedEnabled",
         JReactNativeFeatureFlagsCxxInterop::cxxNativeAnimatedEnabled),
-      makeNativeMethod(
-        "cxxNativeAnimatedRemoveJsSync",
-        JReactNativeFeatureFlagsCxxInterop::cxxNativeAnimatedRemoveJsSync),
       makeNativeMethod(
         "disableEarlyViewCommandExecution",
         JReactNativeFeatureFlagsCxxInterop::disableEarlyViewCommandExecution),