chore(deps): Update GitHub Actions (major) (#1388)

* chore(deps): Update GitHub Actions

| datasource  | package                       | from   | to     |
| ----------- | ----------------------------- | ------ | ------ |
| github-tags | actions/checkout              | v4.3.0 | v5.0.0 |
| github-tags | actions/setup-go              | v5.5.0 | v6.0.0 |
| github-tags | actions/stale                 | v9     | v10    |
| github-tags | golangci/golangci-lint-action | v6.5.2 | v9.0.0 |


Signed-off-by: renovate-sh-app[bot] <219655108+renovate-sh-app[bot]@users.noreply.github.com>

---------

Signed-off-by: renovate-sh-app[bot] <219655108+renovate-sh-app[bot]@users.noreply.github.com>
Co-authored-by: renovate-sh-app[bot] <219655108+renovate-sh-app[bot]@users.noreply.github.com>
Co-authored-by: Andres Martinez Gotor <andres.martinez@grafana.com>

Author: renovate-sh-app[bot]

.github/workflows/check-grafana-compatibility.yml

@@ -17,16 +17,16 @@ jobs:
     permissions:
       contents: read
     steps:
-      - uses: actions/checkout@08eba0b27e820071cde6df949e0beb9ba4906955 # v4.3.0
+      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
         with:
           persist-credentials: false
           path: "./grafana-plugin-sdk-go"
-      - uses: actions/checkout@08eba0b27e820071cde6df949e0beb9ba4906955 # v4.3.0
+      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
         with:
           persist-credentials: false
           repository: "grafana/grafana"
           path: "./grafana"
-      - uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # 5.5.0
+      - uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # 6.0.0
         with:
           cache: false
           go-version: "~1.22"

.github/workflows/check-incompatibility.yml

@@ -17,11 +17,11 @@ jobs:
     permissions:
       contents: read
     steps:
-    - uses: actions/checkout@08eba0b27e820071cde6df949e0beb9ba4906955 # v4.3.0
+    - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
       with:
         persist-credentials: false
         path: './grafana-plugin-sdk-go'
-    - uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # 5.5.0
+    - uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # 6.0.0
       with:
         cache: false
         check-latest: true

.github/workflows/ci.yml

@@ -15,19 +15,19 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@08eba0b27e820071cde6df949e0beb9ba4906955 # v4.3.0
+        uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
         with:
           persist-credentials: false
 
       - name: Setup go
-        uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # 5.5.0
+        uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # 6.0.0
         with:
           go-version-file: ./go.mod
 
       - name: Run golangci-lint
-        uses: golangci/golangci-lint-action@55c2c1448f86e01eaae002a5a3a9624417608d84 # v6.5.2
+        uses: golangci/golangci-lint-action@0a35821d5c230e903fcfe077583637dea1b27b47 # v9.0.0
         with:
-          version: v1.64.2
+          version: v2.4.0
           args: |
             "./..." --timeout=7m
           skip-cache: true

.github/workflows/stale.yml

@@ -9,7 +9,7 @@ jobs:
   stale:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/stale@5bef64f19d7facfb25b37b414482c7164d639639 # v9
+      - uses: actions/stale@5f858e3efba33a5ca4407a664cc011ad407f2008 # v10
         with:
           # Number of days of inactivity before a stale Issue or Pull Request is closed.
           # Set to -1 to disable. If disabled, issues still need to be closed manually, but will remain marked as stale.

.github/workflows/validate-protos.yml

@@ -16,7 +16,7 @@ jobs:
       contents: read
     steps:
       # Run `git checkout`
-      - uses: actions/checkout@08eba0b27e820071cde6df949e0beb9ba4906955 # v4.3.0
+      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
         with:
           persist-credentials: false
       # Install the `buf` CLI

.golangci.toml

@@ -1,45 +1,22 @@
-[issues]
-exclude-files = ["data/.*\\.gen\\.go", "data/generic_nullable_vector\\.go", "data/generic_vector\\.go"]
-
-[linters-settings.goconst]
-min-len = 5
-min-occurrences = 5
-
-[linters-settings.revive]
-ignore-generated-header = false
-
-[linters-settings.misspell]
-ignore-words = ["unknwon"]
-
-[linters-settings.depguard.rules.main]
-allow = [] # allow all
-deny = [
-  { pkg = "io/ioutil", desc = "Deprecated: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details." },
-]
+version = "2"
 
 [linters]
-disable-all = true
 enable = [
   "bodyclose",
-  "depguard",
   "dogsled",
   "errcheck",
   "gochecknoinits",
   "goconst",
   "gocritic",
-  "goimports",
   "goprintffuncname",
   "gosec",
-  "gosimple",
   "govet",
   "ineffassign",
   "misspell",
   "nakedret",
   "rowserrcheck",
   "copyloopvar",
   "staticcheck",
-  "stylecheck",
-  "typecheck",
   "unconvert",
   "unused",
   "whitespace",
@@ -50,14 +27,4 @@ enable = [
   "errorlint",
   "sqlclosecheck",
   "thelper",
-  "revive"
 ]
-# Don't require that errors are included through wrapping, since might not always want to wrap an error
-[[issues.exclude-rules]]
-linters = ["errorlint"]
-text = "non-wrapping format verb for fmt.Errorf"
-[[issues.exclude-rules]]
-linters = ["staticcheck"]
-text = "SA1019"
-[linters-settings.gosec]
-excludes = ["G115"]

Magefile.go

@@ -1,5 +1,4 @@
 //go:build mage
-// +build mage
 
 package main
 

backend/app/manage_example_test.go

@@ -49,7 +49,7 @@ func (ds *testApp) CheckHealth(_ context.Context, _ *backend.CheckHealthRequest)
 	if err != nil {
 		return nil, err
 	}
-	resp.Body.Close()
+	_ = resp.Body.Close()
 	return nil, nil
 }
 
@@ -60,7 +60,7 @@ func (ds *testApp) handleTest(rw http.ResponseWriter, _ *http.Request) {
 		rw.WriteHeader(500)
 		return
 	}
-	resp.Body.Close()
+	_ = resp.Body.Close()
 }
 
 func Example() {

backend/config_test.go

@@ -201,8 +201,8 @@ func TestAppURL(t *testing.T) {
 	})
 
 	t.Run("it should return the configured app URL from env", func(t *testing.T) {
-		os.Setenv(AppURL, "http://localhost-env:3000")
-		defer os.Unsetenv(AppURL)
+		_ = os.Setenv(AppURL, "http://localhost-env:3000")
+		defer func() { _ = os.Unsetenv(AppURL) }()
 		cfg := NewGrafanaCfg(map[string]string{})
 		v, err := cfg.AppURL()
 		require.NoError(t, err)
@@ -354,8 +354,8 @@ func TestPluginAppClientSecret(t *testing.T) {
 	})
 
 	t.Run("it should return the configured PluginAppClientSecret from env", func(t *testing.T) {
-		os.Setenv(AppClientSecret, "client-secret")
-		defer os.Unsetenv(AppClientSecret)
+		_ = os.Setenv(AppClientSecret, "client-secret")
+		defer func() { _ = os.Unsetenv(AppClientSecret) }()
 		cfg := NewGrafanaCfg(map[string]string{})
 		v, err := cfg.PluginAppClientSecret()
 		require.NoError(t, err)

backend/convert_to_protobuf.go

@@ -220,9 +220,9 @@ func (t ConvertToProtobuf) QueryDataResponse(res *QueryDataResponse) (*pluginv2.
 			}
 		}
 		if status.IsValid() {
-			pDR.Status = int32(status)
+			pDR.Status = int32(status) // #nosec G115 -- Status values are HTTP status codes (100-599), always fit in int32
 		} else if status == 0 {
-			pDR.Status = int32(StatusOK)
+			pDR.Status = int32(StatusOK) // #nosec G115 -- StatusOK is 200, always fits in int32
 		}
 		pDR.ErrorSource = string(dr.ErrorSource)
 
@@ -242,7 +242,7 @@ func (t ConvertToProtobuf) CallResourceResponse(resp *CallResourceResponse) *plu
 
 	return &pluginv2.CallResourceResponse{
 		Headers: headers,
-		Code:    int32(resp.Status),
+		Code:    int32(resp.Status), // #nosec G115 -- HTTP status codes (100-599) always fit in int32
 		Body:    resp.Body,
 	}
 }