fix: CodeRabbit review

Author: pdaoust

.cspell/custom-words.txt

@@ -49,7 +49,11 @@ NixOS
 nixpkgs
 pkgs
 POSIX
+prevalidate
+prevalidated
 prevalidates
+prevalidating
+prevalidation
 privkey
 pubkey
 QUIC

src/pages/build/identifiers.md

@@ -37,7 +37,7 @@ Here's an overview of the five types above, plus the two composite types:
 * `ExternalHash` is the ID of a resource that exists outside the database, such as the hash of an IPFS resource or the public key of an Ethereum wallet. Holochain doesn't care about its value, as long as it's 32 bytes long. There's no content stored at the address; it simply serves as an anchor to attach [links](/build/links-paths-and-anchors/) to.
 * Composite types --- if one of the types above is eligible, it can be converted into one of these two types via the `.into()` method. Functions that take the below types will implicitly convert from the above types.
     * `AnyDhtHash` is the hash of any kind of addressable content (actions, entries, and agent public keys). Any
-    * `AnyLinkableHash` is the hash of anything that can be linked to or from (that is, all of the above, or `AnyDhtHash` + `ExternalHash`).
+    * `AnyLinkableHash` is the hash of anything that can be linked to or from (that is, all of the above, or `AnyDhtHash` or `ExternalHash`).
 
 ## Getting hashes
 

src/pages/build/must-get-host-functions.md

@@ -15,7 +15,7 @@ If a `must_get_*` function can't retrieve the data, it isn't considered a valida
 To get a single entry, use [`must_get_entry`](https://docs.rs/hdi/latest/hdi/entry/fn.must_get_entry.html). To get a single action, use [`must_get_action`](https://docs.rs/hdi/latest/hdi/entry/fn.must_get_action.html).
 
 !!! info Results aren't guaranteed to be valid
-Neither of these functions verify that the retrieved data is valid. If you need this assurance, use an action hash as as a dependency's identifier and retrieve it with [`must_get_valid_record`](#must-get-valid-record).
+Neither of these functions verify that the retrieved data is valid. If you need this assurance, use an action hash as a dependency's identifier and retrieve it with [`must_get_valid_record`](#must-get-valid-record).
 !!!
 
 This example validates a [movie loan acceptance](/build/identifiers/#in-dht-data), making sure that it's valid against the original loan offer.
@@ -105,7 +105,7 @@ pub fn validate_not_spamming_movies(action: Action) -> ExternResult<ValidateCall
     // The result is a vector of `RegisterAgentActivity`` DHT ops.
     // Let's convert it into a count of the movie creation actions written in
     // the last minute.
-    let take_until_timestamp = action.timestamp().saturating_add(&Duration::new(60, 0));
+    let lower_bound = action.timestamp().saturating_sub(&Duration::new(60, 0));
     let movie_entry_def = &EntryType::App(UnitEntryTypes::Movie.try_into()?);
     let movies_written_within_window = result
         .iter()

src/pages/concepts/4_dht.md

@@ -169,7 +169,7 @@ Let's see what happens when a simple 'create entry' record is published to the D
 
 No matter what operation they receive, all three authorities check the signature on it to make sure it hasn't been modified in transit and it belongs to the agent that claims to have authored it. If the signature check fails, the data is rejected.
 
-After this first check, the authorities runs the data through the proper system and app-level **validation rules**, then sign the result and return it to the author as a **validation receipt**.
+After this first check, the authorities run the data through the proper system and app-level **validation rules**, then sign the result and return it to the author as a **validation receipt**.
 
 If validation fails, the validator also generates a **warrant**, which is a signed proof that the author has broken a rule. They then publish this warrant to the agent activity authorities, who keep the warrant on file. Any peer who receives a warrant, either via gossip or by requesting invalid data, validates it against the data that's claimed to be invalid, then blocks network communications with the warranted author. This is what creates Holochain's immune system.
 

src/pages/concepts/6_crud_actions.md

@@ -80,7 +80,7 @@ In the future Holochain might introduce 'purge' and 'withdraw' action types, whi
 * All data in the source chain and DHT is immutable once it's written. Nothing is ever deleted.
 * It's useful to be able to modify data, so Holochain offers delete and update actions that simulate mutability by adding status-changing metadata to existing data.
 * Because this may surprise users, developers have a responsibility to inform them of the permanence of data and protect them from negative consequences.
-* In the future we intend to introduce actions that request the actual deletion of data.
+* In the future we may introduce actions that request the actual deletion of data.
 
 
 !!! learn Learn more

src/pages/concepts/7_validation.md

@@ -310,7 +310,7 @@ Some reasons for ejecting an agent from a network simply shouldn't be encoded in
 * Validation supports intrinsic data integrity, which upholds the security of a Holochain app.
 * Validation rules can be written for an agent's entry into an application, the shape and content of data, rules for interaction, write permissions, and write throttling.
 * An author validates their own entries before committing them to their source chain or publishing them to the DHT.
-* Peers in the DHT subject all public data to validation before before storing. This validation uses the same rules that the author used at the time of commit.
+* Peers in the DHT subject all public data to validation before storing. This validation uses the same rules that the author used at the time of commit.
 * If all data upon which a validation depends can be retrieved, the result of a validation function is a clear yes/no result. It proves whether the author has hacked their software to produce invalid entries.
 * If some data dependencies can't be retrieved from the DHT, the conductor will fail with an 'unresolved dependencies' error and try again later.
 * If the validity of an operation depends on existing DHT data, a validating agent can generally trust in the existing validation results on those dependencies instead of having to revalidate them.

src/pages/resources/glossary.md

@@ -124,8 +124,8 @@ A [zome function](#zome-function) call made between [cells](#cell) in one [agent
 The act of packaging:
 
 1. one or more [zomes](#zome) into a [DNA bundle](#dna-bundle),
-2. one or more DNA bundles into a [hApp bundle](#h-app-bundle), or
-3. a hApp bundle and a UI into a [web hApp](#web-h-app).
+2. one or more DNA bundles into a [hApp bundle](#happ-bundle), or
+3. a hApp bundle and a UI into a [web hApp](#web-happ).
 
 #### Byzantine fault tolerance (BFT)
 
@@ -257,7 +257,7 @@ An algorithm that governs the synchronization of data in a [distributed system](
 
 #### Coordinator zome
 
-A [zome](#zome) that defines [zome functions](#zome-function). Arbitrary public zome functions give a DNA [DNA](#dna) its API which mediates interactions between [clients](#client) and a [cell](#cell) instantiated from the DNA, while arbitrary private zome functions can be [scheduled](#scheduling), and special private zome functions with reserved names are called by the [conductor](#conductor) as a consequence of lifecycle events such as [cell initialization](#init-callback) and [source chain commits](#post-commit-callback). Zome functions in a coordinator zome have access to most of the [host API](#holochain-host-api), including the ability to:
+A [zome](#zome) that defines [zome functions](#zome-function). Arbitrary public zome functions give a [DNA](#dna) its API which mediates interactions between [clients](#client) and a [cell](#cell) instantiated from the DNA, while arbitrary private zome functions can be [scheduled](#scheduling), and special private zome functions with reserved names are called by the [conductor](#conductor) as a consequence of lifecycle events such as [cell initialization](#init-callback) and [source chain commits](#post-commit-callback). Zome functions in a coordinator zome have access to most of the [host API](#holochain-host-api), including the ability to:
 
 * write to the [source chain](#source-chain) of the [agent](#agent) running the [cell](#cell) (with the exception of the post-commit callback),
 * read from the [source chain](#source-chain) of the agent running the cell, or from the [DHT](#distributed-hash-table-dht) that the cell belongs to,
@@ -463,13 +463,13 @@ A protocol used by many [peer-to-peer](#peer-to-peer) networks to rapidly propag
 
 In Holochain terms, a [client](#client) that presents a visual way for a user to interact with a [hApp](#holochain-application-happ) running in their [conductor](#conductor). As with any client of a Holochain application, the GUI must possess a [capability](#capability) allowing them to call the hApp's public [zome functions](#zome-function).
 
-#### hApp bundle
+#### hApp bundle {#happ-bundle}
 
-One or more [DNAs](#dna), which together form the [back end](#back-end) for a complete [hApp](#holochain-application-happ). These components are specified in a [hApp manifest](#h-app-manifest) file, and can be packaged together in a zip archive along with the manifest or downloaded separately from the internet. A hApp can also be bundled with a web-based [GUI](#graphical-user-interface-gui) to become a [web hApp](#web-h-app).
+One or more [DNAs](#dna), which together form the [back end](#back-end) for a complete [hApp](#holochain-application-happ). These components are specified in a [hApp manifest](#happ-manifest) file, and can be packaged together in a zip archive along with the manifest or downloaded separately from the internet. A hApp can also be bundled with a web-based [GUI](#graphical-user-interface-gui) to become a [web hApp](#web-happ).
 
-#### hApp manifest
+#### hApp manifest {#happ-manifest}
 
-A file that specifies the DNAs comprising a [hApp bundle](#h-app-bundle).
+A file that specifies the DNAs comprising a [hApp bundle](#happ-bundle).
 
 #### Hash
 
@@ -497,7 +497,7 @@ Holochain's standard Rust-based software development kit (SDK) for [DNA](#dna) d
 
 #### Holochain application (hApp) {#holochain-application-happ}
 
-A collection of [DNAs](#dna) in a [hApp bundle](#h-app-bundle) and optionally a [client](#client) or clients that allow users to interact with those DNAs.
+A collection of [DNAs](#dna) in a [hApp bundle](#happ-bundle) and optionally a [client](#client) or clients that allow users to interact with those DNAs.
 
 #### Holochain Core
 
@@ -945,7 +945,7 @@ A warrant can be used by any peer as legitimate grounds for blocking communicati
 
 A low-level program byte code format that can be run on almost any platform, including the web browser. Holochain expects [zomes](#zome) to be compiled to WebAssembly so the [ribosome](#ribosome) can execute them. See [WebAssembly website](https://webassembly.org/).
 
-#### Web hApp
+#### Web hApp {#web-happ}
 
 A [hApp](#holochain-application-happ) [bundled](#bundling) with a web-based UI.