Skip to content

Conversation

@shajoezhu
Copy link
Contributor

What changes are proposed in this pull request?

  • Style this entry in a way that can be copied directly into NEWS.md. (#, @)

Provide more detail here as needed.

Reference GitHub issue associated with pull request. e.g., 'closes #'


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
  • Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

@shajoezhu shajoezhu requested a review from ddsjoberg December 5, 2025 22:49
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

Unit Tests Summary

  1 files   70 suites   1m 29s ⏱️
 70 tests  70 ✅ 0 💤 0 ❌
176 runs  176 ✅ 0 💤 0 ❌

Results for commit 93a4ec8.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
tbl_hierarchical_rate_and_count 💀 $0.00$ $-0.00$ $-2$ $0$ $0$ $0$
tbl_hierarchical_rate_by_grade 💀 $0.00$ $-0.00$ $-4$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
modify_header_rm_md 👶 $+0.08$ unnamed
tbl_baseline_chg 💚 $13.50$ $-9.00$ tbl_baseline_chg_works
tbl_hierarchical_rate_and_count 💀 $0.00$ $-0.00$ tbl_hierarchical_rate_and_count_digits_styling_defaults_to_gtsummary
tbl_hierarchical_rate_and_count 💀 $0.00$ $-0.00$ tbl_hierarchical_rate_and_count_sort_
tbl_hierarchical_rate_and_count 💀 $18.60$ $-18.60$ tbl_hierarchical_rate_and_count_works
tbl_hierarchical_rate_and_count 💀 $0.00$ $-0.00$ tbl_hierarchical_rate_and_count_works_only_with_2_or_3_variables
tbl_hierarchical_rate_by_grade 💀 $0.00$ $-0.00$ tbl_hierarchical_rate_by_grade_error_messaging_works
tbl_hierarchical_rate_by_grade 💀 $0.00$ $-0.00$ tbl_hierarchical_rate_by_grade_filter_works
tbl_hierarchical_rate_by_grade 💀 $0.00$ $-0.00$ tbl_hierarchical_rate_by_grade_grade_groups_works_with_some_grades_not_in_groups
tbl_hierarchical_rate_by_grade 💀 $0.00$ $-0.00$ tbl_hierarchical_rate_by_grade_grades_exclude_works
tbl_hierarchical_rate_by_grade 💀 $0.00$ $-0.00$ tbl_hierarchical_rate_by_grade_include_overall_works
tbl_hierarchical_rate_by_grade 💀 $0.02$ $-0.02$ tbl_hierarchical_rate_by_grade_keep_zero_rows_works
tbl_hierarchical_rate_by_grade 💀 $0.00$ $-0.00$ tbl_hierarchical_rate_by_grade_sort_works
tbl_hierarchical_rate_by_grade 💀 $5.49$ $-5.49$ tbl_hierarchical_rate_by_grade_works
tbl_hierarchical_rate_by_grade 💀 $0.00$ $-0.00$ tbl_hierarchical_rate_by_grade_works_with_add_overall_
tbl_hierarchical_rate_by_grade 💀 $0.00$ $-0.00$ tbl_hierarchical_rate_by_grade_works_with_non_factor_grade_variables
tbl_survfit_quantiles 💚 $6.13$ $-5.23$ tbl_survfit_quantiles_works
theme_gtsummary_roche 💚 $3.33$ $-3.24$ theme_gtsummary_roche_works

Results for commit c5149d5

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

badge

Code Coverage Summary

Filename                               Stmts    Miss  Cover    Missing
-----------------------------------  -------  ------  -------  ---------
R/add_blank_rows.R                        63       0  100.00%
R/add_difference_row.R                   101       0  100.00%
R/add_hierarchical_count_row.R            33       0  100.00%
R/crane-package.R                          2       2  0.00%    17-18
R/deprecated.R                             6       6  0.00%    15-21
R/label_roche.R                           72       0  100.00%
R/modify_header_rm_md.R                   18       2  88.89%   35-36
R/modify_zero_recode.R                    13       0  100.00%
R/tbl_baseline_chg.R                     186       0  100.00%
R/tbl_hierarchical_rate_and_count.R      148       0  100.00%
R/tbl_hierarchical_rate_by_grade.R       271       3  98.89%   162-164
R/tbl_listing.R                           35       0  100.00%
R/tbl_null_report.R                        9       0  100.00%
R/tbl_roche_summary.R                     64       0  100.00%
R/tbl_shift.R                            116       0  100.00%
R/tbl_survfit_quantiles.R                132       1  99.24%   295
R/tbl_survfit_times.R                     92       0  100.00%
R/theme_gtsummary_roche.R                 74       0  100.00%
R/utils.R                                 36       0  100.00%
TOTAL                                   1471      14  99.05%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 93a4ec8

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@shajoezhu shajoezhu marked this pull request as draft December 6, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants