Multi-database support in inheritance accessors. #550
Conversation
|
Hi @Spikiii - The project has recently moved under a new team. If possible could you rebase this PR against Also, could you provide a unit test for you changes? Thanks! |
bckohan
left a comment
bckohan
left a comment
There was a problem hiding this comment.
I added a test and confirmed the change fixes this issue. One slight adjustment to remove the kwargs check for using because the closure value would be stale during delete().
Thanks for this!
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #550 +/- ##
=======================================
Coverage 75.53% 75.53%
=======================================
Files 21 21
Lines 1345 1345
Branches 213 213
=======================================
Hits 1016 1016
Misses 257 257
Partials 72 72 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bckohan
changed the title
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: ekaplan1 <eytan.kaplan@nasa.gov> Co-authored-by: bckohan <bckohan@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3 participants
This was an issue that kept popping up in a work project that utilizes django-polymorphic. Specifically, the issue was that django-polymorphic didn't respect multiple databases for deletion, causing it to repeatedly error out if the object didn't exist in the
defaultdatabase, but did exist in thetarget_db.I've verified that this change passes the tests, as outlined in the community contribution guidelines.