Skip to content

Desktop: Resolves: #13804: Change search Resources feature to case insensitive #13824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Desktop: Resolves: #13804: Change search Resources feature to case insensitive #13824

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41b348d
Desktop: Resolves: #13804: Change search Resources feature to case in…
bhorbowicz Nov 30, 2025
c1d7823
Fix Resource filtering logic
bhorbowicz Dec 1, 2025
9d6934b
Use toLowerCase in Resource filtering
bhorbowicz Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions packages/app-desktop/gui/ResourceScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,13 @@ const ResourceTableComp = (props: ResourceTable) => {
};

const filteredResources = props.resources.filter(
(resource: InnerResource) => !props.filter || resource.title?.includes(props.filter) || resource.id.includes(props.filter),
(resource: InnerResource) => {
if (props.filter) {
const filterLowerCase = props.filter.toLowerCase();
return resource.title?.toLowerCase().includes(filterLowerCase) || resource.id.toLowerCase().includes(filterLowerCase);
}
return true;
},
);

const renderSortableHeader = (title: string, order: SortingOrder) => {
Expand Down Expand Up @@ -297,15 +303,15 @@ class ResourceScreenComponent extends React.Component<Props, State> {
<div style={{ ...theme.notificationBox, marginBottom: 10 }}>{
_('This is an advanced tool to show the attachments that are linked to your notes. Please be careful when deleting one of them as they cannot be restored afterwards.')
}</div>
<div style={{ float: 'right' }}>
<p style={{ float: 'left', paddingRight: 10 }}>
<input
style={theme.inputStyle}
type="search"
value={this.state.filter}
onChange={this.onFilterUpdate}
placeholder={_('Search...')}
/>
</div>
</p>
{this.state.isLoading && <div>{_('Please wait...')}</div>}
{!this.state.isLoading && <div>
{!this.state.resources && <div>
Expand Down