-
Notifications
You must be signed in to change notification settings - Fork 469
Open
Description
As I was reading through the source code, I've listed some minor issues which may improve the project:
- Route guards (Currently we can move to the login page by typing the address in the URL bar even when we are already logged in)
mapValidationResponsedoes not handle403error- No need to write
<template #default>for suspense - Enforce an import order convention
- Reset errors when re-submitting the forms
useArticlescomposable:
6.1. InfetchArticlesfunction, sincearticleTypecan only have one value, it's better to useif-elserather than onlyifto skip other checks.
6.2getArticlesMetafunction is acting like a composable. So maybe it's better to rename it touseArticlesMeta- Vue docs doesn't recommend using generic argument for
reactive(). So it may be better to change current generic usage. - In
AppLinkcomponent,useAttrsandv-bind="attrs"can be removed because of Fallthrough Attributes - Add "Not Found" page
I would like to help fix these issues if they are valid to you. :D
mutoe and Likilee
Metadata
Metadata
Assignees
Labels
No labels