feat: Add node debug logging #22527
Draft
feat: Add node debug logging #22527
+281
−113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
BundleMonUnchanged files (2)
No change in files bundle size Groups updated (2)
Final result: ✅ View report in BundleMon website ➡️ |
❌ 39 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
|
E2E Tests: n8n tests passed after 10m 20.6s Run Details
Groups
This message was posted automatically by
currents.dev | Integration Settings
|
|
Found 41 test failures on Blacksmith runners: Failures
|
Comment on lines
+316
to
+327
| function copyRequestOptionsForLogs( | ||
| ctx: IAllExecuteFunctions, | ||
| requestOptions: IHttpRequestOptions, | ||
| ): IHttpRequestOptions | null; | ||
| function copyRequestOptionsForLogs( | ||
| ctx: IAllExecuteFunctions, | ||
| requestOptions: IRequestOptions, | ||
| ): IRequestOptions | null; | ||
| function copyRequestOptionsForLogs( | ||
| ctx: IAllExecuteFunctions, | ||
| requestOptions: IRequestOptions | IHttpRequestOptions, | ||
| ): IRequestOptions | IHttpRequestOptions | null { |
Contributor
There was a problem hiding this comment.
maybe better with generics?
| secrets = getSecrets(properties, credentials); | ||
| } | ||
| const sanitizedRequestOptions = sanitizeUiMessage(requestOptions, authKeys, secrets); | ||
| ctx.sendMessageToUI(sanitizedRequestOptions); |
Contributor
There was a problem hiding this comment.
you can use a new nodeDebugLogger as it would also use logger
e.g. ctx.nodeDebugLogger(sanitizedRequestOptions, 'Request Options');
Contributor
There was a problem hiding this comment.
Because we format JSON, each request takes a lot of space in logs and I had some security concerns, so I just sent it to UI
Comment on lines
351
to
354
| // TODO: change to nodeDebugLogger and log request to server logs? | ||
| const ctxCompatible = 'sendMessageToUI' in ctx; | ||
| const canLog = node.nodeDebugLogs && ctx.getMode?.() === 'manual' && requestOptions !== null; | ||
| if (ctxCompatible && canLog) { |
Contributor
There was a problem hiding this comment.
we probably need to do this check once and have in context
yehorkardash
reviewed
Dec 1, 2025
|
|
||
| getExecutionContext: () => IExecutionContext | undefined; | ||
|
|
||
| nodeDebugLogger(message: any, tag?: string): void; |
Contributor
There was a problem hiding this comment.
I'd prefer to have nodeLogger with methods log(), debug(), warn(), error()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a Node team hack week project to improve debug logging for nodes.
Related Linear tickets, Github issues, and Community forum posts
s #", or "resolves #" to automatically close issues when the PR is merged. -->
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)