fix(core): During partial execution don't include loop as start node if the loop isn't closed #22555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
n8n-assistant
bot
added
core
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
|
E2E Tests: n8n tests passed after 9m 51.5s Run Details
Groups
This message was posted automatically by
currents.dev | Integration Settings
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In partial executions, while searching for the start nodes, if we see a Loop node we check the output at index 0 (the
doneoutput). If there's no data, we treat the whole loop as needing to be re-run.However, some Loop nodes don't actually represent a loop in the graph e.g., while a workflow is under development. In this case we want to check the
loopoutput (index 1) to determine whether it should be included as a start node.Related Linear tickets, Github issues, and Community forum posts
Closes https://linear.app/n8n/issue/CAT-891.
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)