Skip to content

Conversation

@AgnieszkaZaba
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.62%. Comparing base (e4ddacd) to head (c981940).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1748   +/-   ##
=======================================
  Coverage   86.62%   86.62%           
=======================================
  Files         413      413           
  Lines       10471    10471           
=======================================
  Hits         9070     9070           
  Misses       1401     1401           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@slayoo
Copy link
Member

slayoo commented Nov 27, 2025

@AgnieszkaZaba. pylint complains addressed/silenced

@AgnieszkaZaba
Copy link
Collaborator Author

@slayoo the issue was with autoupdate:

From https://pre-commit.com/


You can update your hooks to the latest version automatically by running [pre-commit autoupdate](https://pre-commit.com/#pre-commit-autoupdate). By default, this will bring the hooks to the latest tag on the default branch.

When we do release it should be ok.

@AgnieszkaZaba
Copy link
Collaborator Author

I think we need something like this package for MacOS: intel-openmp (https://numba.pydata.org/numba-doc/0.50.0/user/threading-layer.html)
I am not sure where to specify it - in setup.py or in workflows?

@AgnieszkaZaba
Copy link
Collaborator Author

It can be installed via conda:
conda install intel-openmp

@slayoo
Copy link
Member

slayoo commented Dec 6, 2025

Thanks @AgnieszkaZaba !

For the record:

  • in pip_install_on_colab('PySDM-examples', 'PySDM'), indicating PySDM is redundant as it is a dependency of PySDM-examples (but adding it here does no harm)
  • when we specify a particular version, then we need to specify the same version for both packages, hence we need pip_install_on_colab('PySDM-examples>X.Y.Z', 'PySDM>X.Y.Z')

@slayoo slayoo changed the title add check-badges hook add check-badges hook; set NUMBA_THREADING_LAYER to 'workqueue' in all notebooks with uniform experience across all OSes in mind; Dec 6, 2025
@slayoo slayoo changed the title add check-badges hook; set NUMBA_THREADING_LAYER to 'workqueue' in all notebooks with uniform experience across all OSes in mind; add check-badges hook; set NUMBA_THREADING_LAYER to 'workqueue' in all notebooks with uniform experience across all OSes in mind Dec 6, 2025
@slayoo
Copy link
Member

slayoo commented Dec 6, 2025

We're now setting the workqueue threading backend for all notebooks, but we never run tests with it.

Let's either add another matrix dimension in the .yml test workflows to have both omp and workqueue covered, or - as a simpler solution - we can set the same env var for all the tests (and remove the currently used run: echo NUMBA_THREADING_LAYER=omp >> $GITHUB_ENV)

Copy link
Member

@slayoo slayoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add workqueue setting for tests as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants