refactor: Simplify image reference in port-ocean chart

- Introduced a new helper function to standardize the container image retrieval process.
- Updated deployment and cron job templates to utilize the new helper function for image definition, enhancing maintainability and clarity.

Author: yaelibarg

charts/port-ocean/templates/_helpers.tpl

@@ -186,6 +186,13 @@ Get default image
 port-ocean-{{ .Values.integration.type }}:{{ .Values.integration.version | default "latest" }}
 {{- end }}
 
+{{/*
+Get container image (registry + image name)
+*/}}
+{{- define "port-ocean.image" -}}
+{{ .Values.imageRegistry }}/{{ .Values.image | default (include "port-ocean.defaultImage" .) }}
+{{- end }}
+
 {{/*
 Get deployment name
 */}}

charts/port-ocean/templates/actions-processor/deployment.yaml

@@ -44,7 +44,7 @@ spec:
       containers:
       - name: {{ include "port-ocean.containerName" . }}
         imagePullPolicy: {{ .Values.imagePullPolicy }}
-        image: '{{ .Values.imageRegistry }}/{{ .Values.image | default (include "port-ocean.defaultImage" .) }}'
+        image: {{ include "port-ocean.image" . }}
         {{- if .Values.service.enabled }}
         securityContext:
           {{- if .Values.containerSecurityContext }}

charts/port-ocean/templates/cron-job/cron.yaml

@@ -132,7 +132,7 @@ spec:
           containers:
           - name: {{ include "port-ocean.containerName" . }}
             imagePullPolicy: {{ .Values.imagePullPolicy }}
-            image: '{{ .Values.imageRegistry }}/{{ .Values.image | default (include "port-ocean.defaultImage" .) }}'
+            image: {{ include "port-ocean.image" . }}
             {{- if .Values.service.enabled }}
             securityContext:
               {{- if .Values.containerSecurityContext }}

charts/port-ocean/templates/deployment-live-events.yaml

@@ -57,7 +57,7 @@ spec:
       containers:
       - name: {{ include "port-ocean.containerName" . }}
         imagePullPolicy: {{ .Values.imagePullPolicy }}
-        image: '{{ .Values.imageRegistry }}/{{ .Values.image | default (include "port-ocean.defaultImage" .) }}'
+        image: {{ include "port-ocean.image" . }}
         {{- if .Values.service.enabled }}
         securityContext:
           {{- if .Values.containerSecurityContext }}

charts/port-ocean/templates/deployment.yaml

@@ -55,7 +55,7 @@ spec:
       containers:
       - name: {{ include "port-ocean.containerName" . }}
         imagePullPolicy: {{ .Values.imagePullPolicy }}
-        image: '{{ .Values.imageRegistry }}/{{ .Values.image | default (include "port-ocean.defaultImage" .) }}'
+        image: {{ include "port-ocean.image" . }}
         {{- if .Values.service.enabled }}
         securityContext:
           {{- if .Values.containerSecurityContext }}