(feat): Add support for custom container image name in port-ocean chart #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced `imageName` field in values.yaml to allow users to specify a custom container image name. - Added a helper function to generate the default image name based on integration type and version. - Updated deployment templates to utilize the new `imageName` field, falling back to the default if not provided.
- Updated values.yaml to change `imageName` field to `image` for clarity. - Modified helper function to reflect the new image naming convention. - Adjusted deployment templates to use the updated `image` field, ensuring backward compatibility with default image generation.
- Introduced a new helper function to standardize the container image retrieval process. - Updated deployment and cron job templates to utilize the new helper function for image definition, enhancing maintainability and clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
imageNamefield in values.yaml to allow users to specify a custom container image name.imageNamefield, falling back to the default if not provided.Type of change
Please leave one option from the following and delete the rest: