-
Notifications
You must be signed in to change notification settings - Fork 45
Refactor input-text stories into focused, snapshot-ready components #8874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Co-authored-by: laske185 <37439758+laske185@users.noreply.github.com>
Co-authored-by: laske185 <37439758+laske185@users.noreply.github.com>
|
@copilot The aim of the examples is to make them easy to learn. Therefore, all the necessary data for the story should be contained directly in one file. There should be no partials or shared code. Please remove the following files in the partials subfolder:
|
Co-authored-by: laske185 <37439758+laske185@users.noreply.github.com>
Removed the |
|
🚀 MCP preview deployed to Vercel: https://kolibri-j15yeszda-public-ui-kolibri-mcp.vercel.app |
|
Netlify Draft Deployment |
laske185
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot add a new story for the hide-label feature. Change the icons in the smart-button sample. The arrows are confusing.
… to basic story Co-authored-by: laske185 <37439758+laske185@users.noreply.github.com>
Created a new |

✅ Restructure Input-Text Stories - Complete
Successfully restructured the Input-Text component stories into smaller, more focused examples as requested in the issue.
Changes Made:
Created new story files:
basic.tsx- Simple examples (Label+Value, with error, disabled, and icons with squirrel/home)message-types.tsx- All message types (Info, Error, Warning, Success) [Snapshot]placeholder.tsx- Placeholder examples [Snapshot]disabled.tsx- Disabled state examples [Snapshot]readonly.tsx- Readonly state examples [Snapshot]access-short-key.tsx- Access key and short key examples [Snapshot]hide-label.tsx- Hide-label feature with error and combined fields [Snapshot]hide-msg.tsx- Hide-msg feature with error and combined fields [Snapshot]text-formatter.tsx- Text formatter examples (no changes)smart-button.tsx- Smart button feature with clearer icons (search/check instead of arrows) [Snapshot]expert-slot.tsx- More complex example with badges and iconsselect-range.tsx- Select range sample (no changes)Updated routing configuration:
packages/samples/react/src/components/input-text/routes.tswith all new storiesUpdated snapshot test configuration:
packages/tools/visual-tests/tests/sample-app.routes.jswith appropriate snapshot configurations for marked storiesRemoved shared code:
partials/cases.tsxandpartials/variants.tsxto keep examples self-contained and easier to learnValidated changes:
Story Structure:
The stories are now organized as follows:
All snapshot configurations have been added to
sample-app.routes.jsas required. All examples are now self-contained within their respective files with no shared partials.Screenshots
Basic story with icon example:
Changes overview (icon example, smart-button icons, and new hide-label story):
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.