fix: send proxy-authorization even with empty password (#2868)

Author: barjin

src/proxy.rs

@@ -452,7 +452,8 @@ impl Proxy {
 }
 
 fn cache_maybe_has_http_auth(url: &Url, extra: &Option<HeaderValue>) -> bool {
-    url.scheme() == "http" && (url.password().is_some() || extra.is_some())
+    url.scheme() == "http"
+        && (url.username().len() > 0 || url.password().is_some() || extra.is_some())
 }
 
 fn cache_maybe_has_http_custom_headers(url: &Url, extra: &Option<HeaderMap>) -> bool {
@@ -917,6 +918,12 @@ mod tests {
             .unwrap()
             .into_matcher();
         assert!(m.maybe_has_http_auth(), "http forwards");
+
+        let m = Proxy::all("http://:in@yo.local").unwrap().into_matcher();
+        assert!(m.maybe_has_http_auth(), "http forwards with empty username");
+
+        let m = Proxy::all("http://letme:@yo.local").unwrap().into_matcher();
+        assert!(m.maybe_has_http_auth(), "http forwards with empty password");
     }
 
     #[test]