code_style: change UpdateSelectedChunk from public to protected

Signed-off-by: leo <longshuang@msn.cn>

Author: love-linger

src/Views/TextDiffView.axaml.cs

@@ -478,10 +478,6 @@ public ThemedTextDiffPresenter(TextArea area, TextDocument doc) : base(area, doc
             TextArea.TextView.LineTransformers.Add(_lineStyleTransformer);
         }
 
-        public virtual void UpdateSelectedChunk(double y)
-        {
-        }
-
         public void GotoChange(ViewModels.BlockNavigationDirection direction)
         {
             if (DataContext is not ViewModels.TextDiffContext ctx)
@@ -603,6 +599,10 @@ protected override void OnSizeChanged(SizeChangedEventArgs e)
             }
         }
 
+        protected virtual void UpdateSelectedChunk(double y)
+        {
+        }
+
         private async void OnTextAreaKeyDown(object sender, KeyEventArgs e)
         {
             if (e.KeyModifiers.Equals(OperatingSystem.IsMacOS() ? KeyModifiers.Meta : KeyModifiers.Control))
@@ -889,7 +889,62 @@ public class CombinedTextDiffPresenter : ThemedTextDiffPresenter
             TextArea.LeftMargins.Add(new LineModifyTypeMargin());
         }
 
-        public override void UpdateSelectedChunk(double y)
+        protected override void OnLoaded(RoutedEventArgs e)
+        {
+            base.OnLoaded(e);
+
+            _scrollViewer = this.FindDescendantOfType<ScrollViewer>();
+            if (_scrollViewer != null)
+            {
+                _scrollViewer.Bind(ScrollViewer.OffsetProperty, new Binding("ScrollOffset", BindingMode.TwoWay));
+                _scrollViewer.ScrollChanged += OnTextViewScrollChanged;
+            }
+        }
+
+        protected override void OnUnloaded(RoutedEventArgs e)
+        {
+            if (_scrollViewer != null)
+                _scrollViewer.ScrollChanged -= OnTextViewScrollChanged;
+
+            base.OnUnloaded(e);
+        }
+
+        protected override void OnDataContextChanged(EventArgs e)
+        {
+            base.OnDataContextChanged(e);
+
+            if (DataContext is ViewModels.CombinedTextDiff { Data: { } diff })
+            {
+                var builder = new StringBuilder();
+                foreach (var line in diff.Lines)
+                {
+                    if (line.Content.Length > 10000)
+                    {
+                        builder.Append(line.Content.AsSpan(0, 1000));
+                        builder.Append($"...({line.Content.Length - 1000} characters trimmed)");
+                    }
+                    else
+                    {
+                        builder.Append(line.Content);
+                    }
+
+                    if (line.NoNewLineEndOfFile)
+                        builder.Append("\u26D4");
+
+                    builder.AppendLine();
+                }
+
+                Text = builder.ToString();
+            }
+            else
+            {
+                Text = string.Empty;
+            }
+
+            GC.Collect();
+        }
+
+        protected override void UpdateSelectedChunk(double y)
         {
             if (DataContext is not ViewModels.CombinedTextDiff { Data: { } diff } combined)
                 return;
@@ -988,39 +1043,75 @@ public override void UpdateSelectedChunk(double y)
             }
         }
 
+        private void OnTextViewScrollChanged(object sender, ScrollChangedEventArgs e)
+        {
+            if (!TextArea.TextView.IsPointerOver)
+                TrySetChunk(null);
+        }
+
+        private ScrollViewer _scrollViewer = null;
+    }
+
+    public class SingleSideTextDiffPresenter : ThemedTextDiffPresenter
+    {
+        public SingleSideTextDiffPresenter() : base(new TextArea(), new TextDocument())
+        {
+            TextArea.LeftMargins.Add(new LineNumberMargin(true, false));
+            TextArea.LeftMargins.Add(new VerticalSeparatorMargin());
+            TextArea.LeftMargins.Add(new LineModifyTypeMargin());
+        }
+
+        protected override void OnPropertyChanged(AvaloniaPropertyChangedEventArgs change)
+        {
+            base.OnPropertyChanged(change);
+
+            if (change.Property == BlockNavigationProperty)
+            {
+                if (change.OldValue is ViewModels.BlockNavigation oldValue)
+                    oldValue.PropertyChanged -= OnBlockNavigationPropertyChanged;
+                if (change.NewValue is ViewModels.BlockNavigation newValue)
+                    newValue.PropertyChanged += OnBlockNavigationPropertyChanged;
+            }
+        }
+
         protected override void OnLoaded(RoutedEventArgs e)
         {
             base.OnLoaded(e);
 
             _scrollViewer = this.FindDescendantOfType<ScrollViewer>();
             if (_scrollViewer != null)
             {
-                _scrollViewer.Bind(ScrollViewer.OffsetProperty, new Binding("ScrollOffset", BindingMode.TwoWay));
                 _scrollViewer.ScrollChanged += OnTextViewScrollChanged;
+                _scrollViewer.Bind(ScrollViewer.OffsetProperty, new Binding("ScrollOffset", BindingMode.OneWay));
             }
         }
 
         protected override void OnUnloaded(RoutedEventArgs e)
         {
             if (_scrollViewer != null)
+            {
                 _scrollViewer.ScrollChanged -= OnTextViewScrollChanged;
+                _scrollViewer = null;
+            }
 
             base.OnUnloaded(e);
+            GC.Collect();
         }
 
         protected override void OnDataContextChanged(EventArgs e)
         {
             base.OnDataContextChanged(e);
 
-            if (DataContext is ViewModels.CombinedTextDiff { Data: { } diff })
+            if (DataContext is ViewModels.TwoSideTextDiff diff)
             {
                 var builder = new StringBuilder();
-                foreach (var line in diff.Lines)
+                var lines = IsOld ? diff.Old : diff.New;
+                foreach (var line in lines)
                 {
-                    if (line.Content.Length > 10000)
+                    if (line.Content.Length > 1000)
                     {
                         builder.Append(line.Content.AsSpan(0, 1000));
-                        builder.Append($"...({line.Content.Length - 1000} character trimmed)");
+                        builder.Append($"...({line.Content.Length - 1000} characters trimmed)");
                     }
                     else
                     {
@@ -1039,29 +1130,9 @@ protected override void OnDataContextChanged(EventArgs e)
             {
                 Text = string.Empty;
             }
-
-            GC.Collect();
         }
 
-        private void OnTextViewScrollChanged(object sender, ScrollChangedEventArgs e)
-        {
-            if (!TextArea.TextView.IsPointerOver)
-                TrySetChunk(null);
-        }
-
-        private ScrollViewer _scrollViewer = null;
-    }
-
-    public class SingleSideTextDiffPresenter : ThemedTextDiffPresenter
-    {
-        public SingleSideTextDiffPresenter() : base(new TextArea(), new TextDocument())
-        {
-            TextArea.LeftMargins.Add(new LineNumberMargin(true, false));
-            TextArea.LeftMargins.Add(new VerticalSeparatorMargin());
-            TextArea.LeftMargins.Add(new LineModifyTypeMargin());
-        }
-
-        public override void UpdateSelectedChunk(double y)
+        protected override void UpdateSelectedChunk(double y)
         {
             if (DataContext is not ViewModels.TwoSideTextDiff diff)
                 return;
@@ -1163,77 +1234,6 @@ public override void UpdateSelectedChunk(double y)
             }
         }
 
-        protected override void OnPropertyChanged(AvaloniaPropertyChangedEventArgs change)
-        {
-            base.OnPropertyChanged(change);
-
-            if (change.Property == BlockNavigationProperty)
-            {
-                if (change.OldValue is ViewModels.BlockNavigation oldValue)
-                    oldValue.PropertyChanged -= OnBlockNavigationPropertyChanged;
-                if (change.NewValue is ViewModels.BlockNavigation newValue)
-                    newValue.PropertyChanged += OnBlockNavigationPropertyChanged;
-            }
-        }
-
-        protected override void OnLoaded(RoutedEventArgs e)
-        {
-            base.OnLoaded(e);
-
-            _scrollViewer = this.FindDescendantOfType<ScrollViewer>();
-            if (_scrollViewer != null)
-            {
-                _scrollViewer.ScrollChanged += OnTextViewScrollChanged;
-                _scrollViewer.Bind(ScrollViewer.OffsetProperty, new Binding("ScrollOffset", BindingMode.OneWay));
-            }
-        }
-
-        protected override void OnUnloaded(RoutedEventArgs e)
-        {
-            if (_scrollViewer != null)
-            {
-                _scrollViewer.ScrollChanged -= OnTextViewScrollChanged;
-                _scrollViewer = null;
-            }
-
-            base.OnUnloaded(e);
-            GC.Collect();
-        }
-
-        protected override void OnDataContextChanged(EventArgs e)
-        {
-            base.OnDataContextChanged(e);
-
-            if (DataContext is ViewModels.TwoSideTextDiff diff)
-            {
-                var builder = new StringBuilder();
-                var lines = IsOld ? diff.Old : diff.New;
-                foreach (var line in lines)
-                {
-                    if (line.Content.Length > 1000)
-                    {
-                        builder.Append(line.Content.AsSpan(0, 1000));
-                        builder.Append($"...({line.Content.Length - 1000} characters trimmed)");
-                    }
-                    else
-                    {
-                        builder.Append(line.Content);
-                    }
-
-                    if (line.NoNewLineEndOfFile)
-                        builder.Append("\u26D4");
-
-                    builder.AppendLine();
-                }
-
-                Text = builder.ToString();
-            }
-            else
-            {
-                Text = string.Empty;
-            }
-        }
-
         private void OnTextViewScrollChanged(object sender, ScrollChangedEventArgs e)
         {
             if (_scrollViewer == null || DataContext is not ViewModels.TwoSideTextDiff diff)