tests: improve coverage

Author: dupdob

src/Stryker.Core/Stryker.Core.UnitTest/Initialisation/InitialBuildProcessTests.cs

@@ -132,6 +132,26 @@ public void InitialBuildProcess_ShouldUseCustomMsbuildIfNotNull()
             Times.Once);
     }
 
+    [TestMethod]
+    public void InitialBuildProcess_ShouldUseProvidedConfiguration()
+    {
+        var processMock = new Mock<IProcessExecutor>(MockBehavior.Strict);
+        var mockFileSystem = new MockFileSystem();
+
+        processMock.SetupProcessMockToReturn("");
+
+        var target = new InitialBuildProcess(processMock.Object, mockFileSystem);
+
+        target.InitialBuild(false, "/", "./ExampleProject.sln", "TheDebug");
+        processMock.Verify(x => x.Start(It.IsAny<string>(),
+                It.IsAny<string>(),
+                It.Is<string>(argumentsParam => argumentsParam.Contains("-c TheDebug")),
+                It.IsAny<IEnumerable<KeyValuePair<string, string>>>(),
+                It.IsAny<int>()),
+            Times.Once);
+    }
+
+
     [TestMethod]
     public void InitialBuildProcess_ShouldRunDotnetBuildIfNotDotnetFramework()
     {

src/Stryker.Core/Stryker.Core.UnitTest/Initialisation/InputFileResolverTests.cs

@@ -256,6 +256,95 @@ public void ShouldHandleFailedAnalysis()
         action.ShouldThrow<InputException>();
     }
 
+    [TestMethod]
+    public void ShouldFailIfSolutionNotFound()
+    {
+        var fileSystem = new MockFileSystem(new Dictionary<string, MockFileData>
+        {
+            { _sourceProjectPath, new MockFileData(_defaultTestProjectFileContents) },
+            { _testProjectPath, new MockFileData(_defaultTestProjectFileContents)},
+            { Path.Combine(_sourcePath, "Recursive.cs"), new MockFileData(_sourceFile) },
+            { Path.Combine(_sourcePath, "Plain.cs"), new MockFileData(_sourceFile) },
+        });
+
+        var sourceProjectManagerMock = SourceProjectAnalyzerMock(_sourceProjectPath,
+            fileSystem.AllFiles.Where(s => s.EndsWith(".cs")).ToArray());
+        var testProjectManagerMock = TestProjectAnalyzerMock(_testProjectPath, _sourceProjectPath, ["netcoreapp2.1"], success: false);
+
+        var analyzerResults = new Dictionary<string, IProjectAnalyzer>
+        {
+            { "MyProject", sourceProjectManagerMock.Object },
+            { "MyProject.UnitTests", testProjectManagerMock.Object }
+        };
+        BuildBuildAnalyzerMock(analyzerResults);
+        var options = new StrykerOptions()
+        {
+            ProjectPath = _sourcePath,
+            SolutionPath = Path.Combine(_sourcePath, "solution.nope")
+        };
+        var target = new InputFileResolver(fileSystem,
+            BuildalyzerProviderMock.Object,
+            _nugetMock.Object);
+
+        var action = () => target.ResolveSourceProjectInfos(options).First();
+        action.ShouldThrow<InvalidOperationException>();
+    }
+
+    [TestMethod]
+    public void ShouldFailIfSolutionLoadFails()
+    {
+        var fileSystem = new MockFileSystem(new Dictionary<string, MockFileData>());
+
+        var sourceProjectManagerMock = SourceProjectAnalyzerMock(_sourceProjectPath,
+            fileSystem.AllFiles.Where(s => s.EndsWith(".cs")).ToArray());
+        var testProjectManagerMock = TestProjectAnalyzerMock(_testProjectPath, _sourceProjectPath, ["netcoreapp2.1"], success: false);
+
+        var analyzerResults = new Dictionary<string, IProjectAnalyzer>
+        {
+            { "MyProject", sourceProjectManagerMock.Object },
+            { "MyProject.UnitTests", testProjectManagerMock.Object }
+        };
+        BuildBuildAnalyzerMock(analyzerResults);
+        var options = new StrykerOptions()
+        {
+            ProjectPath = _sourcePath,
+            SolutionPath = Path.Combine(_sourcePath, "solution.sln")
+        };
+        var target = new InputFileResolver(fileSystem,
+            BuildalyzerProviderMock.Object,
+            _nugetMock.Object, _ => throw new IOException("Failed to read solution"));
+
+        var action = () => target.ResolveSourceProjectInfos(options).First();
+        action.ShouldThrow<InvalidOperationException>();
+    }
+    [TestMethod]
+    public void ShouldFailIfSolutionCantBeAccessed()
+    {
+        var fileSystem = new MockFileSystem(new Dictionary<string, MockFileData>());
+
+        var sourceProjectManagerMock = SourceProjectAnalyzerMock(_sourceProjectPath,
+            fileSystem.AllFiles.Where(s => s.EndsWith(".cs")).ToArray());
+        var testProjectManagerMock = TestProjectAnalyzerMock(_testProjectPath, _sourceProjectPath, ["netcoreapp2.1"], success: false);
+
+        var analyzerResults = new Dictionary<string, IProjectAnalyzer>
+        {
+            { "MyProject", sourceProjectManagerMock.Object },
+            { "MyProject.UnitTests", testProjectManagerMock.Object }
+        };
+        BuildBuildAnalyzerMock(analyzerResults);
+        var options = new StrykerOptions()
+        {
+            ProjectPath = _sourcePath,
+            SolutionPath = Path.Combine(_sourcePath, "solution.slnx")
+        };
+        var target = new InputFileResolver(fileSystem,
+            BuildalyzerProviderMock.Object,
+            _nugetMock.Object, _ => throw new UnauthorizedAccessException("Access forbidden"));
+
+        var action = () => target.ResolveSourceProjectInfos(options).First();
+        action.ShouldThrow<UnauthorizedAccessException>();
+    }
+
     [TestMethod]
     public void InitializeShouldNotSkipXamlFiles()
     {

src/Stryker.Core/Stryker.Core/Initialisation/InputFileResolver.cs

@@ -68,7 +68,6 @@ public IReadOnlyCollection<SourceProjectInfo> ResolveSourceProjectInfos(IStryker
         Dictionary<IAnalyzerResult, List<IAnalyzerResult>> findMutableAnalyzerResults;
         if (options.IsSolutionContext)
         {
-
             SolutionFile solution;
 
             try

src/Stryker.Solutions/SolutionFile.cs

@@ -10,8 +10,6 @@ public class SolutionFile
 
     public HashSet<string> GetBuildTypes() => _configurations.Keys.Select(x => x.buildType).ToHashSet();
 
-    public HashSet<string> GetPlatforms() => _configurations.Keys.Select(x => x.platform).ToHashSet();
-
     public bool ConfigurationExists(string buildType, string? platform = null) => _configurations.Keys.Any(x => x.buildType == buildType && (platform == null || platform == x.platform));
 
     public IReadOnlyCollection<string> GetProjects(string buildType, string? platform = null)