New solution support #3340
Open
New solution support #3340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for solution file parsing and platform configuration in Stryker.NET. The changes introduce a new Stryker.Solutions library that leverages Microsoft.VisualStudio.SolutionPersistence to parse solution files and extract project configurations.
Key changes:
- New
Stryker.Solutionslibrary withSolutionFileclass for parsing Visual Studio solution files - Support for specifying platform (e.g., "Any CPU") alongside configuration when building projects
- Refactored
InputFileResolverto use solution file parsing when analyzing solution contexts - Updated
StrykerOptionsto support platform configuration through the Configuration property - Multiple code quality improvements including null safety, simplified LINQ expressions, and better error handling
Reviewed Changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated 31 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Stryker.sln | Added two new projects: Stryker.Solutions and Stryker.Solutions.Test |
| src/Stryker.Solutions/SolutionFile.cs | New class for parsing and querying Visual Studio solution files |
| src/Stryker.Solutions/Stryker.Solutions.csproj | New project file for the Solutions library |
| src/Stryker.Solutions.Test/* | New test project with comprehensive tests for SolutionFile functionality |
| src/Stryker.Utilities/Buildalyzer/IAnalyzerResultExtensions.cs | Refactored with improved null annotations, simplified LINQ, and moved helper class to bottom |
| src/Stryker.Utilities/Buildalyzer/Buildalyzer.cs | Removed unused overload taking solution file path |
| src/Stryker.Options/Options/StrykerOptions.cs | Added Platform property and logic to parse it from Configuration string |
| src/Stryker.Options/Options/Inputs/ConfigurationInput.cs | Updated description and removed whitespace validation |
| src/Stryker.Core/Stryker.Core/Initialisation/InputFileResolver.cs | Major refactoring to use SolutionFile for solution context analysis |
| src/Stryker.Core/Stryker.Core/Initialisation/InitialBuildProcess.cs | Added platform parameter support |
| src/Stryker.Core/Stryker.Core/Helpers/MsBuildHelper.cs | Added platform parameter to build commands |
| src/Stryker.Core/Stryker.Core.UnitTest/* | Updated tests to accommodate new parameters and solution provider |
| src/Directory.Packages.props | Added Microsoft.VisualStudio.SolutionPersistence package |
src/Stryker.Core/Stryker.Core/Initialisation/InputFileResolver.cs
Outdated
Show resolved
Hide resolved
src/Stryker.Core/Stryker.Core/Initialisation/InputFileResolver.cs
Outdated
Show resolved
Hide resolved
src/Stryker.Core/Stryker.Core/Initialisation/InitialisationProcess.cs
Outdated
Show resolved
Hide resolved
src/Stryker.Core/Stryker.Core/Initialisation/InputFileResolver.cs
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 33 out of 33 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
src/Stryker.Core/Stryker.Core/Initialisation/InputFileResolver.cs:1
- This test verifies that an
InvalidOperationExceptionis thrown when the solution is not found, but the implementation at line 62 inSolutionFile.csthrowsInvalidOperationException, while the error handling inInputFileResolver.cs(lines 77-91) catchesIOException,UnauthorizedAccessException, andAggregateException. The test should verify the logged error and empty return, not an exception being thrown.
using System;
src/Stryker.Core/Stryker.Core/Initialisation/InitialisationProcess.cs
Outdated
Show resolved
Hide resolved
dupdob
force-pushed
the
new_solution_support
branch
from
618520e to
d20788a
Compare
src/Stryker.Core/Stryker.Core/Initialisation/InputFileResolver.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
|
@dupdob it will be at least two weeks before I am able to review, sorry |
# Conflicts: # src/Directory.Packages.props # src/Stryker.CLI/Stryker.CLI.UnitTest/packages.lock.json # src/Stryker.CLI/Stryker.CLI/packages.lock.json # src/Stryker.Core/Stryker.Core.UnitTest/packages.lock.json # src/Stryker.TestRunner.VsTest.UnitTest/packages.lock.json
|
dupdob
added
the
Priority: High
Open
|
Any chance to approve this and release soon? |
This comment has been minimized.
This comment has been minimized.
Member
|
Anyone waiting on this can expedite the process by helping review and test the PR 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reach 'full' support of solutions:
snlxfiles (on top of sln files)Support of solution level configurations offers permits to define a Stryker specific configuration(s) to exclude some project for example.
Platform can be specified via the `|'.
May fix #3269