stm32: u5: allow selection of VOS via DT #100319
Conversation
|
@petrosyan-van could you please give some feedback on this? 🙂 |
zephyrbot
added
area: Power Management
area: Devicetree Bindings
area: Boards/SoCs
Release Notes
zephyrbot
requested review from
FRASTM,
GeorgeCGV,
JordanYates,
cfriedt,
djiatsaf-st,
erwango,
etienne-lms,
gautierg-st,
jhedberg,
juickar,
kartben,
nashif,
nordic-krch,
teburd and
tmleman
mathieuchopstm
force-pushed
the
topic/stm32u5_dt_vos_cfg
branch
from
8e74004 to
f916d18
Compare
Thanks for this PR! I will try it out in upcoming days and will let you know :) |
| +---------+----------------+-----------------------------------+ | ||
| | 3 | 55 MHz | [1] | | ||
| +---------+----------------+-----------------------------------+ | ||
| | 4 | 25 MHz | [1][2]; lowest power consumption | |
There was a problem hiding this comment.
in udc_stm32.c we have:
/* Check that power range is 1 or 2 */
if (LL_PWR_GetRegulVoltageScaling() < LL_PWR_REGU_VOLTAGE_SCALE2) {
LOG_ERR("Wrong Power range to use USB OTG HS");
return -EIO;
}
there is no check if it's OTG_HS or OTG_FS. Seems the requirement is to have at least scale 2 in the code
There was a problem hiding this comment.
The code in UDC driver is overzealous - the table is correct and based on STM32U5 series Reference Manual:
The UDC driver should definitely be fixed, but this is a separate issue outside PR scope.
mathieuchopstm
force-pushed
the
topic/stm32u5_dt_vos_cfg
branch
from
f916d18 to
70587c3
Compare
|
Added missing |
| +---------+----------------+-----------------------------------+ | ||
| | 3 | 55 MHz | [1] | | ||
| +---------+----------------+-----------------------------------+ | ||
| | 4 | 25 MHz | [1][2]; lowest power consumption | |
There was a problem hiding this comment.
Nit:
| | 4 | 25 MHz | [1][2]; lowest power consumption | | |
| | 4 | 25 MHz | Lowest power consumption [1][2] | |
There was a problem hiding this comment.
Done + saved a few characters at the right of table.
| Controls two voltage regulators which can output one voltage | ||
| among four different ranges depending on use case. | ||
| among four different voltage scales, depending on use case. |
|
I tried with |
Add a binding for the power controller of STM32U5 series. Signed-off-by: Mathieu Choplain <mathieu.choplain-ext@st.com>
Add the "st,stm32u5-pwr" compatible to the Power Controller node in the DTSI for STM32U5 series. Signed-off-by: Mathieu Choplain <mathieu.choplain-ext@st.com>
Add support for the new `voltage-scale` property on the STM32U5-specific Power Controller binding. Signed-off-by: Mathieu Choplain <mathieu.choplain-ext@st.com>
Add new voltage scale selection property for STM32U5 to 4.4 release notes. Signed-off-by: Mathieu Choplain <mathieu.choplain-ext@st.com>
mathieuchopstm
force-pushed
the
topic/stm32u5_dt_vos_cfg
branch
from
70587c3 to
0757899
Compare
We have no plan at the moment for supporting dynamic voltage scaling on STM32 platforms. If you want such functionality, you will have to roll your own implementation (note that the LL API can be used by the application through the |
|
4 participants
Allow selecting a voltage scale using Device Tree on STM32U5 series. This is notably useful when a high system clock frequency is not required, but the application still wants to use the USB IPs which are only available in certain ranges.
Fixes #98641.