fix: [FLOWISE-1] Unstable Redis, ECONNREFUSED 127.0.0.1

[natan-hoppe-workday]

Description

Added dedicated class RedisConnector to initialize and connect to Redis while supporting sync and async usages, as well reconnections in case of failures.

Updated the following files with its usage:

• packages/server/src/CachePool.ts
• packages/server/src/enterprise/middleware/passport/SessionPersistance.ts
• packages/server/src/utils/rateLimit.ts

[gemini-code-assist]

Summary of Changes

Hello @natan-hoppe-workday, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the stability and maintainability of Redis interactions within the application by consolidating all Redis connection and initialization logic into a dedicated RedisConnector class. This change addresses potential issues with unstable Redis connections by providing a robust, centralized mechanism for managing Redis clients, including automatic reconnection capabilities and standardized configuration parsing, thereby improving overall system reliability.

Highlights

• New RedisConnector Class: A new RedisConnector class has been introduced in packages/components/src/RedisConnector.ts. This class centralizes the logic for initializing and connecting to a Redis instance, supporting both synchronous and asynchronous usage patterns.
• Robust Redis Connection Handling: The RedisConnector handles various Redis configuration options from environment variables (e.g., REDIS_URL, REDIS_HOST, REDIS_TLS, REDIS_KEEP_ALIVE, REDIS_CERT, etc.) and includes built-in reconnection logic (reconnectOnError) to improve stability against connection failures.
• Refactored Redis Client Usage: Existing direct ioredis client instantiations across the codebase have been refactored to utilize the new RedisConnector. This includes updates in CachePool.ts, SessionPersistance.ts, and rateLimit.ts, ensuring a consistent and centralized approach to Redis connectivity.
• Simplified Redis Integration: The new class abstracts away complex Redis initialization details, providing simple getRedisClient() and getRedisConnection() methods, which trigger lazy initialization and ensure the client is ready for use.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a RedisConnector class to centralize and improve Redis connection handling, which is a great initiative. The refactoring correctly applies this new connector across CachePool, SessionPersistance, and rateLimit. However, the implementation of RedisConnector has a critical flaw in how it provides the Redis client instance synchronously, which will lead to runtime errors. There's also an issue with the reconnection logic's implementation not matching its documented intent. My review focuses on these key areas to ensure the connector is robust and reliable.

[HenryHengZJ]

We also need to test if the modified pieces related to Redis (cache, session, rate limit, etc) works on dev server