fix: invocation of GetFilterFinalScorerPrompt #394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
函数调用缺少括号，system_prompt 应当接受字符串作为参数
Collaborator
|
@Fengzhongzhihan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
开发者你们好，我在使用 core_filter.py 时注意到 GetFilterFinalScorerPrompt 的函数调用缺少括号。检查 PromptedGenerator 发现 system_prompt 应当接受字符串作为参数，因此我认为不应该直接传入函数对象。如有误会还请指正，谢谢。