feat: Add jks to supported formats #6153
Open
+84
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkna-sap
requested changes
Nov 13, 2025
davidkna-sap
reviewed
Dec 3, 2025
Co-authored-by: David Knaack <david.knaack@sap.com>
davidkna-sap
reviewed
Dec 3, 2025
Comment on lines
+140
to
+142
| if (!destination.keyStorePassword) { | ||
| throw Error('Keystore password is required for JKS format'); | ||
| } |
Member
There was a problem hiding this comment.
AFAICT this is optional and removing it might help with the most recent update by the user.
Suggested change
| if (!destination.keyStorePassword) { | |
| throw Error('Keystore password is required for JKS format'); | |
| } |
davidkna-sap
reviewed
Dec 3, 2025
| The node client supports only these store formats https://nodejs.org/api/tls.html#tlscreatesecurecontextoptions. | ||
| */ | ||
| const supportedCertificateFormats = ['p12', 'pfx', 'pem']; | ||
| const supportedCertificateFormats = ['p12', 'pfx', 'pem', 'jks']; |
Member
There was a problem hiding this comment.
Not completely sure, but I think this can be listed there too now:
Suggested change
| const supportedCertificateFormats = ['p12', 'pfx', 'pem', 'jks']; | |
| const supportedCertificateFormats = ['p12', 'pfx', 'pem', 'jks', 'keystore']; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes SAP/ai-sdk-js-backlog#358.