Skip to content

code review #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rottenmu wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

code review #280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2d90e6c
提交 femas 灰度测试代码
rottenmu Nov 7, 2022
63d5345
提交 随机权重算法以及测试代码
rottenmu Nov 7, 2022
7585874
1.code review
rottenmu Nov 10, 2022
0834463
Merge branch 'polarismesh:develop' into develop
rottenmu Nov 10, 2022
3c24a7e
Merge branch 'polarismesh:develop' into develop
rottenmu May 25, 2023
6358037
Merge branch 'TencentFemas:develop' into develop
rottenmu Aug 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions femas-example/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
<module>feams-example-springcloud-hoxton</module>
<module>femas-example-apache-dubbo3</module>
<module>femas-example-springcloud-discovery</module>
<module>femas-gray-example-springcloud-consumer</module>
<module>femas-gray-example-springcloud-provider</module>
</modules>

<parent>
Expand Down
9 changes: 1 addition & 8 deletions ...c/main/java/com/tencent/tsf/femas/extensions/dubbo/registry/FemasApacheDubboRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@

import com.tencent.tsf.femas.api.ExtensionManager;
import com.tencent.tsf.femas.api.IExtensionLayer;
import com.tencent.tsf.femas.common.context.Context;
import com.tencent.tsf.femas.common.context.ContextConstant;
import com.tencent.tsf.femas.common.context.factory.ContextFactory;
import com.tencent.tsf.femas.common.entity.Service;
Expand All @@ -13,8 +12,6 @@
import org.apache.dubbo.common.URL;
import org.apache.dubbo.common.constants.CommonConstants;
import org.apache.dubbo.common.constants.RegistryConstants;
import org.apache.dubbo.common.logger.Logger;
import org.apache.dubbo.common.logger.LoggerFactory;
import org.apache.dubbo.common.utils.UrlUtils;
import org.apache.dubbo.registry.Constants;
import org.apache.dubbo.registry.NotifyListener;
Expand All @@ -28,21 +25,17 @@

/**
* apache dubbo registry center implementation for femas
* @author rottenmu
*/

public class FemasApacheDubboRegistry extends FailbackRegistry {
private final Logger logger = LoggerFactory.getLogger(getClass());

private static volatile ContextConstant contextConstant = ContextFactory.getContextConstantInstance();
private static String namespace = Context.getSystemTag(contextConstant.getNamespaceId());
private IExtensionLayer extensionLayer = ExtensionManager.getExtensionLayer();
private static final String group = Context.getSystemTag(contextConstant.getGroupId());

public FemasApacheDubboRegistry(URL url) {
super(url);
ServiceInstance instance = createServiceInstance(url);
Service service = CommonUtils.buildService(url);
// Service service = new Service(namespace, url.getParameter("application"));
extensionLayer.init(service, url.getPort());
instance.setPort(url.getPort());
instance.setService(service);
Expand Down