WIP: Rework E2E fixtures and add roles #25553
Draft
+1,092
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jonatansberg
force-pushed
the
ber-3077-rework-fixtures-and-add-roles
branch
4 times, most recently
from
e242d6e to
42edc2a
Compare
refs https://linear.app/ghost/issue/BER-3077/improve-e2e-testing-integration Detect the presence of containers initialized through yarn dev:forward. When present, reuse existing resources and use the lightweight dev backend image and gateway setup for E2E test isolation.
refs https://linear.app/ghost/issue/BER-3077/improve-e2e-testing-integration The yarn dev:forward command won't start Tinybird by default since it's expensive to run. These changes mean that we automatically skip tests that depend on Tinybird when running locally and that service isn't available.
jonatansberg
force-pushed
the
ber-3077-rework-fixtures-and-add-roles
branch
from
42edc2a to
b8a2563
Compare
Contributor
E2E Tests FailedTo view the Playwright test report locally, run: REPORT_DIR=$(mktemp -d) && gh run download 19816734922 -n playwright-report -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR" |
rob-ghost
changed the base branch from
main
to
ber-3077-integrate-e2e-yarn-dev-forward
jonatansberg
force-pushed
the
ber-3077-integrate-e2e-yarn-dev-forward
branch
from
61fe875 to
ec3dd15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #25552