feat(disvocery): Add zookeeper discovery #12772
Conversation
dongjiang1989
changed the title
dongjiang1989
force-pushed
the
add-zookeeper-discovery
branch
from
7bfba46 to
01f70df
Compare
dosubot
bot
added
size:L
Baoyuantop
left a comment
Baoyuantop
left a comment
There was a problem hiding this comment.
Hi @dongjiang1989, thanks for your contribution. Could you add documentation and testing for this feature? You can refer to other service discovery modules for reference.
Thanks @Baoyuantop |
dongjiang1989
force-pushed
the
add-zookeeper-discovery
branch
3 times, most recently
from
3993d37 to
ea3c33e
Compare
dosubot
bot
removed
the
size:L
Signed-off-by: dongjiang1989 <dongjiang1989@126.com> add zookeeper discovery docs Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
dosubot
bot
added
the
size:XL
dongjiang1989
force-pushed
the
add-zookeeper-discovery
branch
from
f25602f to
3435db2
Compare
|
@Baoyuantop Please review docs, thanks |
|
Hi @dongjiang1989, additional tests are needed to verify that the function works correctly. |
| instance_cache:flush_all() | ||
| log.info("zookeeper discovery destroyed") | ||
| end | ||
|
|
There was a problem hiding this comment.
A dump method is also needed to retrieve all services in the current service discovery instance. You can explore other service discovery modules for more information.
| } | ||
|
|
||
| -- Global Configuration | ||
| local local_conf |
There was a problem hiding this comment.
It is recommended that the main process request the service instance from ZooKeeper and synchronize it to the worker processes via the shared dict.
Got it. I'll add UT soon |
2 participants
Description
Which issue(s) this PR fixes:
Fixes #3231 #6687
Add zookeeper discovery
Checklist