Skip to content

Conversation

@shailesh-google
Copy link
Collaborator

@shailesh-google shailesh-google commented Dec 3, 2025

Fixing Performance issue of team list page by Adding Pagination.

Fix For #1150

@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.24%. Comparing base (8227260) to head (cf4afcf).

Files with missing lines Patch % Lines
...e_teams/src/Entity/ListBuilder/TeamListBuilder.php 0.00% 11 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                3.x    #1212   +/-   ##
=========================================
  Coverage     44.24%   44.24%           
  Complexity     3070     3070           
=========================================
  Files           344      344           
  Lines         11235    11235           
=========================================
  Hits           4971     4971           
  Misses         6264     6264           
Files with missing lines Coverage Δ
...e_teams/src/Entity/ListBuilder/TeamListBuilder.php 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@boobaa
Copy link
Contributor

boobaa commented Dec 4, 2025

Hi @shailesh-google ,

Thank you for this pagination patch, which I just gave a try. As a test, I have a local site with drupal/apigee_edge:3.0.13 which is configured to fetch ALL the Apigee-related data for the /teams page from a local endpoint (to eliminate both the network latency AND the time Apigee Edge/OPDK would need to collect and return the data), with some 10k (!) teams.

  • With both this and PR#1210 applied, first 1k of the 10k /teams page load time: 5.1/3.2 secs
  • With both this and PR#1210 applied AND a custom patch (that uses the NullBackend for TeamStorage's cache) also applied, first 1k of the 10k /teams page load time: 2.6/1.4 secs

Also worth noting that while this pagination does decrease the page load times quite a bit, it also removes the possibility to find a particular team by (part of) its name using the browser's find-in-page functionality, as one might have to paginate thru quite a bunch of pages until the correct team is found. The situation is a bit better if the user knows the WHOLE name of the team (or searches for the first part of it), as it's still possible to order this list by the teams' name or status.

To mitigate this, it would be nice to have Views support for listing teams, so the sitebuilder could add some exposed filters as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants