Refactor vllm sm endpoint test to use pytest #5521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sallyseok
commented
Nov 29, 2025
sallyseok
commented
- Updated the vllm sm endpoint test file to match the sglang version using pytest instead of a direct executable
- Also added some constants used across both files
Signed-off-by: Sally Seok <sallyseo@amazon.com>
aws-deep-learning-containers-ci
bot
added
authorized
Size:XL
Signed-off-by: Sally Seok <sallyseo@amazon.com>
Signed-off-by: Sally Seok <sallyseo@amazon.com>
Signed-off-by: Sally Seok <sallyseo@amazon.com>
Signed-off-by: Sally Seok <sallyseo@amazon.com>
Signed-off-by: Sally Seok <sallyseo@amazon.com>
sirutBuasai
reviewed
Dec 2, 2025
| @pytest.fixture(scope="function") | ||
| def instance_type(request): | ||
| # Return the model_id given by the test parameter | ||
| # Return the instance_type given by the test parameter |
sirutBuasai
reviewed
Dec 2, 2025
Signed-off-by: Sally Seok <sallyseo@amazon.com>
sirutBuasai
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.