fix(toolbar): omit inert when batch actions are not present
#2405
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2404
Fixes a regression caused by #2359 where
ToolbarContentwas incorrectly made inert when rows were selected in aDataTable, even when noToolbarBatchActionscomponent was present. This prevented users from interacting with toolbar controls, such as search inputs and buttons, when rows were selected.Previously,
ToolbarContentchecked for selected row IDs from the DataTable context to determine if it should be inert. However, this caused issues when a DataTable had row selection enabled but no batch actions component. The fix tracks the actual visibility state of batch actions through a newbatchActionsActivestore in the Toolbar context, ensuring toolbar content is only inert when batch actions are actually visible.Example of affected usage:
Changes
batchActionsActivewritable store toToolbarcontext to track batch actions visibility stateToolbarBatchActionsto setbatchActionsActivebased on whether batch actions are shownToolbarContentto subscribe tobatchActionsActiveinstead of checkingbatchSelectedIdsfrom DataTable context