Return early if start or stop are null #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

koddsson wants to merge 1 commit into clauderic:master from koddsson:dont-throw-when-size-is-zero

koddsson commented Apr 23, 2020

Hey hey!

This patch should make sure that we don't throw when getVisibleRange returns a empty object:

virtualized-list/src/VirtualList/SizeAndPositionManager.js

Line 121 in d519d57

if (totalSize === 0) { return {}; }

Instead we just return early. Not sure if there is a better way to handle this case.


          return early if start or stop are null

d519d57

MrPancakes39 commented Aug 17, 2021

Why would start or end be null??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet