Skip to content

Conversation

@BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Dec 2, 2025

This PR enables the plugin to use our local TS code instead of a installed NPM package.
I also renamed AutorunExecutor to CliExecutor

depends on #1159

Followup PR will cover testing the logic in runCliExecutor.

@nx-cloud
Copy link

nx-cloud bot commented Dec 2, 2025

View your CI Pipeline Execution ↗ for commit e5e8df0

Command Status Duration Result
nx run ci:code-pushup -- merge-diffs --files=/h... ✅ Succeeded 5s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 1m 22s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 12m 20s View ↗
nx run-many -t unit-test,int-test ✅ Succeeded 1m 48s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-05 14:04:59 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 2, 2025

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1161

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1161

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1161

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1161

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1161

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1161

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1161

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1161

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1161

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1161

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1161

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1161

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1161

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1161

commit: e5e8df0

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Code PushUp

🥳 Code PushUp report has improved – compared current commit f9f8279 with previous commit f74d2dd.

💼 Project nx-plugin

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟡 85 🟡 85 ↑ +0.1

5 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟡 85 🟡 85 ↑ +0.1

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Line coverage 🟨 79.3 % 🟨 79.9 % ↑ +0.7 %
Code coverage Branch coverage 🟨 76.4 % 🟨 76.4 % ↑ +0.1 %

445 other audits are unchanged.


13 other projects are unchanged.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit f9f8279 with previous commit f74d2dd.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 44 🔴 48 ↑ +4.5
Code coverage 🟡 89 🟡 89 ↓ −0.1
Bug prevention 🟡 67 🟡 67
Code style 🟢 100 🟢 100
Security 🔴 43 🔴 43
Updates 🟡 71 🟡 71
Type Safety 🟡 56 🟡 56
Miscellaneous 🟡 67 🟡 67
Documentation 🔴 35 🔴 35
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟢 92 🟢 92
👍 1 group improved, 👎 1 group regressed, 👍 7 audits improved, 👎 1 audit regressed, 13 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 44 🔴 48 ↑ +4.5
Code coverage Code coverage metrics 🟡 89 🟡 89 ↓ −0.1

21 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Initial server response time was short 🟥 Root document took 790 ms 🟩 Root document took 570 ms ↓ −27.3 %
Lighthouse Total Blocking Time 🟥 800 ms 🟥 630 ms ↓ −21 %
Lighthouse Speed Index 🟥 6.7 s 🟥 5.9 s ↓ −10.9 %
Lighthouse Max Potential First Input Delay 🟥 840 ms 🟥 530 ms ↓ −37.2 %
Lighthouse Time to Interactive 🟥 13.0 s 🟥 12.0 s ↓ −8 %
Lighthouse First Contentful Paint 🟥 3.2 s 🟥 3.2 s ↓ −2.6 %
Code coverage Branch coverage 🟨 87.3 % 🟨 87.2 % ↓ −0.1 %
Code coverage Line coverage 🟨 84.7 % 🟨 84.7 % ↑ +0.1 %
Lighthouse Minimizes main-thread work 🟥 7.5 s 🟥 6.1 s ↓ −19.6 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,032 KiB 🟩 Total size was 2,031 KiB ↓ −0.1 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −8 %
Lighthouse Largest Contentful Paint 🟥 11.6 s 🟥 10.7 s ↓ −7.9 %
Lighthouse Server Backend Latencies 🟩 1,760 ms 🟩 870 ms ↓ −50.9 %
Lighthouse JavaScript execution time 🟥 2.9 s 🟥 2.2 s ↓ −23.9 %
Lighthouse Uses efficient cache policy on static assets 🟨 32 resources found 🟨 32 resources found ↓ −0.1 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 186 KiB 🟥 Potential savings of 186 KiB ↑ +9.6 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 105 KiB 🟥 Potential savings of 105 KiB ↓ −10.4 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 104 KiB 🟥 Potential savings of 92 KiB ↓ −10 %
TypeScript Semantic errors 🟥 2623 errors 🟥 2596 errors ↓ −1 %
Lighthouse Network Round Trip Times 🟩 50 ms 🟩 70 ms ↑ +33.9 %
TypeScript No implicit any errors 🟥 96 errors 🟥 94 errors ↓ −2.1 %

657 other audits are unchanged.

# Conflicts:
#	packages/nx-plugin/src/executors/cli/executor.ts
#	packages/nx-plugin/src/executors/cli/executor.unit.test.ts
@BioPhoton BioPhoton marked this pull request as ready for review December 4, 2025 17:43
@BioPhoton BioPhoton requested a review from matejchalk December 4, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants