-
Notifications
You must be signed in to change notification settings - Fork 15
refactor(nx-plugin): add env vars to executor #1161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
# Conflicts: # e2e/nx-plugin-e2e/tests/plugin-create-nodes.e2e.test.ts # packages/nx-plugin/src/executors/cli/executor.ts # packages/nx-plugin/src/executors/cli/executor.unit.test.ts
…-vars-to-executor # Conflicts: # packages/nx-plugin/src/executors/cli/executor.ts
…ugin/add-env-vars-to-executor
|
View your CI Pipeline Execution ↗ for commit e5e8df0
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/axe-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
commit: |
Code PushUp🥳 Code PushUp report has improved – compared current commit f9f8279 with previous commit f74d2dd. 💼 Project
|
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Code coverage | 🟡 85 | 🟡 85 |
5 other categories are unchanged.
👍 1 group improved, 👍 2 audits improved
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| Code coverage | Code coverage metrics | 🟡 85 | 🟡 85 |
14 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| Code coverage | Line coverage | 🟨 79.3 % | 🟨 79.9 % | |
| Code coverage | Branch coverage | 🟨 76.4 % | 🟨 76.4 % |
445 other audits are unchanged.
13 other projects are unchanged.
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit f9f8279 with previous commit f74d2dd. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 1 group improved, 👎 1 group regressed, 👍 7 audits improved, 👎 1 audit regressed, 13 audits changed without impacting score🗃️ Groups
21 other groups are unchanged. 🛡️ Audits
657 other audits are unchanged. |
# Conflicts: # packages/nx-plugin/src/executors/cli/executor.ts # packages/nx-plugin/src/executors/cli/executor.unit.test.ts
This PR enables the plugin to use our local TS code instead of a installed NPM package.
I also renamed
AutorunExecutortoCliExecutordepends on #1159
Followup PR will cover testing the logic in
runCliExecutor.