Skip to content

Conversation

@MiguelCompany
Copy link
Member

Description

This solves the same as #6148 with a different approach, which breaks ABI.
It changes DomainParticipant::get_instance_handle to return by value, and constructs the InstanceHandle_t from the participant's GUID on the fly.

This is similar to what is done for DataWriter and DataReader.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • NO: Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

…value.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany added this to the v3.5.0 milestone Nov 5, 2025
@MiguelCompany MiguelCompany added the no-test Skip CI tests if PR marked with this label label Nov 5, 2025
@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiprosima November 5, 2025 09:49
@github-actions github-actions bot added the ci-pending PR which CI is running label Nov 5, 2025
@MiguelCompany MiguelCompany added blocked-till-branch-out and removed ci-pending PR which CI is running labels Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked-till-branch-out no-test Skip CI tests if PR marked with this label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants