Remove instruction to use plaintext backend for storing GitHub tokens for Unit tests #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for Unit tests First of all, it is insecure to store passwords in plain text. It should be discuoraged, not instructed. Second, `keyring.backends.file.PlaintextKeyring` is no longer part of the keyring API as to discourage insecure storage of passwords. If the developer trying to set up the unit tests tries to follow these instructions verbatum they will fail with the following error: ``` Traceback (most recent call last): File "<stdin>", line 1, in <module> AttributeError: module 'keyring.backends' has no attribute 'file' ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, it is insecure to store passwords in plain text. It should be discuoraged, not instructed.
Second,
keyring.backends.file.PlaintextKeyringis no longer part of the keyring API as to discourage insecure storage of passwords. If the developer trying to set up the unit tests tries to follow these instructions verbatim they will fail with the following error:If, on my CentOS 7 system, I instead skip straight ahead to setting the password using the next line in the documentation all works out fine.