Skip to content

Conversation

@upodroid
Copy link
Contributor

@upodroid upodroid commented Nov 10, 2025

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: upodroid
Once this PR has been reviewed and has the lgtm label, please assign jmhbnz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @upodroid. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ivanvc
Copy link
Member

ivanvc commented Nov 10, 2025

@upodroid, in the etcd repos we use DCO. If you sign your git commit the check will pass.

Thanks for this initiative!

/ok-to-test

@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.13%. Comparing base (0e1d3ca) to head (2e8612c).
⚠️ Report is 30 commits behind head on main.

Additional details and impacted files

see 23 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #20915      +/-   ##
==========================================
- Coverage   69.18%   69.13%   -0.06%     
==========================================
  Files         422      422              
  Lines       34839    34839              
==========================================
- Hits        24104    24085      -19     
- Misses       9334     9353      +19     
  Partials     1401     1401              

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e1d3ca...2e8612c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@upodroid upodroid force-pushed the rework-image-pipeline branch 3 times, most recently from 0073bd1 to 731cdd3 Compare November 11, 2025 01:18
Signed-off-by: upodroid <cy@borg.dev>
@upodroid upodroid force-pushed the rework-image-pipeline branch from 731cdd3 to 2e8612c Compare November 11, 2025 20:39
@k8s-ci-robot
Copy link

@upodroid: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-grpcproxy-e2e-amd64 2e8612c link true /test pull-etcd-grpcproxy-e2e-amd64
pull-etcd-release-tests 2e8612c link true /test pull-etcd-release-tests
pull-etcd-grpcproxy-e2e-arm64 2e8612c link true /test pull-etcd-grpcproxy-e2e-arm64
pull-etcd-verify 2e8612c link true /test pull-etcd-verify
pull-etcd-robustness-amd64 2e8612c link true /test pull-etcd-robustness-amd64
pull-etcd-robustness-arm64 2e8612c link true /test pull-etcd-robustness-arm64
pull-etcd-e2e-arm64 2e8612c link true /test pull-etcd-e2e-arm64
pull-etcd-e2e-amd64 2e8612c link true /test pull-etcd-e2e-amd64
pull-etcd-e2e-386 2e8612c link true /test pull-etcd-e2e-386

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants