-
Notifications
You must be signed in to change notification settings - Fork 10.2k
add support for building images using a ci pipeline #20915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: upodroid The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @upodroid. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@upodroid, in the etcd repos we use DCO. If you sign your git commit the check will pass. Thanks for this initiative! /ok-to-test |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 23 files with indirect coverage changes @@ Coverage Diff @@
## main #20915 +/- ##
==========================================
- Coverage 69.18% 69.13% -0.06%
==========================================
Files 422 422
Lines 34839 34839
==========================================
- Hits 24104 24085 -19
- Misses 9334 9353 +19
Partials 1401 1401 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
0073bd1 to
731cdd3
Compare
Signed-off-by: upodroid <cy@borg.dev>
731cdd3 to
2e8612c
Compare
|
@upodroid: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi
This change should allow prow to build etcd images and binaries after it's merged.
It will also run on tags as well
/hold We need to merge a few other PRs first
@ivanvc
Please have a look at this build that is successful: