-
Notifications
You must be signed in to change notification settings - Fork 122
Update apollo-router to 2.9.0 #7338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @theguild-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs an automatic update of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
📚 Storybook DeploymentThe latest changes are available as preview in: https://pr-7338.hive-storybook.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR updates apollo-router to 2.9.0, which is an automated dependency update. The changes in Cargo.lock are consistent with this update. I've noted an opportunity to consolidate a duplicated dependency version that was introduced.
| [[package]] | ||
| name = "jsonschema" | ||
| version = "0.33.0" | ||
| version = "0.36.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This update introduces jsonschema version 0.36.0 as a transitive dependency through apollo-router. The dev-dependencies in packages/libraries/router/Cargo.toml specify jsonschema = "0.29.0", which resolves to 0.29.1 in the lock file. This results in two different major versions of jsonschema in the dependency tree.
To avoid potential type mismatches in tests and reduce dependency bloat, it's recommended to align the dev-dependency version. Please consider updating the jsonschema dev-dependency in packages/libraries/router/Cargo.toml to ^0.36.0.
💻 Website PreviewThe latest changes are available as preview in: https://pr-7338.hive-landing-page.pages.dev |
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tag: |
53e6959 to
b41ae90
Compare
b41ae90 to
eacec99
Compare
eacec99 to
abde0d8
Compare
abde0d8 to
144c99c
Compare
144c99c to
e913a2c
Compare
e913a2c to
aa29041
Compare
1225be0 to
a02446c
Compare
a02446c to
546881b
Compare
546881b to
c2ff239
Compare
c2ff239 to
8418b88
Compare
8418b88 to
40a32d3
Compare
40a32d3 to
3abff0c
Compare
3abff0c to
6acaccc
Compare
6acaccc to
cc2a8ce
Compare
Automatic update of apollo-router to version 2.9.0.