Skip to content

Conversation

@danigm
Copy link

@danigm danigm commented Jan 17, 2023

This patch adds the new arguments to the types.CodeType class constructor in the clonefunc function.

See #231

This patch adds the new arguments to the types.CodeType class
constructor in the clonefunc function.

See ionelmc#231
@danigm danigm marked this pull request as ready for review January 17, 2023 12:37
@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.43%. Comparing base (7ef2645) to head (254edb6).
⚠️ Report is 91 commits behind head on master.

Files with missing lines Patch % Lines
src/pytest_benchmark/compat.py 0.00% 1 Missing ⚠️
src/pytest_benchmark/utils.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #232      +/-   ##
==========================================
+ Coverage   64.41%   64.43%   +0.01%     
==========================================
  Files          29       29              
  Lines        2858     2862       +4     
  Branches      386      469      +83     
==========================================
+ Hits         1841     1844       +3     
- Misses        927      928       +1     
  Partials       90       90              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Jan 18, 2023
https://build.opensuse.org/request/show/1059005
by user dgarcia + dimstar_suse
- Modify the py311.patch to fix the test_abort_broken test, instead of
  disabling.
- Add py311.patch to make it compatible with python 3.11,
  gh#ionelmc/pytest-benchmark#232
- Disable broken test_abort_broken, this test is broken because the output of
  the tests is a bit different with python 3.11 so we can disable until it's
  fixed.
@ngie-eign
Copy link

.github workflows, etc, needs to be updated.

@ngie-eign
Copy link

I updated setup.py and CHANGELOG.rst in #237 as well. I think that's everything that needs to be done.
I can close my PR in favor of your's.

@ngie-eign
Copy link

LGTM -- but I'm not a contributor, so sorry -- can't provide approval 😅 .

@ngie-eign
Copy link

ngie-eign commented Mar 13, 2023

PS You might need to rebase if you haven't done so recently, since this was originally based on sources from 2 months ago. I wouldn't do anything about that unless it's absolutely needed, or the maintainers ask.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants