-
-
Notifications
You must be signed in to change notification settings - Fork 1
Combine three dependency data structures into single HashSet #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Combine three dependency data structures into single HashSet #129
Conversation
|
Hey @jkeresman01, I think I've been able to do it. Let me know if you find any issues or tweaks that I need to make. Thanks! |
jkeresman01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @devind-ra
Sorry for slow response on this.
When I tried testing your changes I've got this 2 errors.
- When selecting unique dep for the first time.
E5108: Error executing lua: ...alizr.nvim/lua/spring-initializr/telescope/telescope.lua:165: attempt to get length of field 'selected_dependencies' (a nil value)
stack traceback:
...alizr.nvim/lua/spring-initializr/telescope/telescope.lua:165: in function 'record_selection'
...alizr.nvim/lua/spring-initializr/telescope/telescope.lua:205: in function 'on_select'
...alizr.nvim/lua/spring-initializr/telescope/telescope.lua:252: in function 'run_replace_or_original'
...packer/start/telescope.nvim/lua/telescope/actions/mt.lua:65: in function 'key_func'
...k/packer/start/telescope.nvim/lua/telescope/mappings.lua:253: in function <...k/packer/start/telescope.nvim/lua/telescope/mappings.lua:252> - When trying to remove selected dependency.
E5108: Error executing lua: ...alizr.nvim/lua/spring-initializr/telescope/telescope.lua:182: attempt to call method 'remove_key' (a nil value)
stack traceback:
...alizr.nvim/lua/spring-initializr/telescope/telescope.lua:182: in function 'remove_dependency'
...lizr/ui/components/dependencies/dependencies_display.lua:346: in function 'remove_focused_card'
...lizr/ui/components/dependencies/dependencies_display.lua:380: in function <...lizr/ui/components/dependencies/dependencies_display.lua:379>
Press ENTER or type command to continue
Didn't quite catch enough time to pinpoint exact root cause.
Could you also look it up, see if same issue is present from your side.
|
@jkeresman01, no worries. I'll look into the issue on my side as well and see what's going on. Thanks for the review |
|
@jkeresman01, apologies for the delay it was a simpler fix than I thought. Let me know how it works on your side! |
Description
Refactoring usage in tests and files where all three data structures were used.
Fix for issue #110
Type of change
How Has This Been Tested?
Manual testing and unit tests
Configuration:
Checklist: