Skip to content

Conversation

@koxudaxi
Copy link
Owner

@koxudaxi koxudaxi commented Dec 3, 2025

Summary

  • Fix issue where multiple types in array (e.g., type: ["boolean", "object"]) with properties would only generate the object type, ignoring
    other types like boolean
  • Now correctly generates Union[ObjectClass, bool] instead of just
    ObjectClass

Fixes #2488

@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.63%. Comparing base (6ac97d8) to head (e924436).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2590   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files          73       73           
  Lines        8478     8506   +28     
  Branches     1030     1033    +3     
=======================================
+ Hits         8447     8475   +28     
  Misses         14       14           
  Partials       17       17           
Flag Coverage Δ
unittests 99.63% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 3, 2025

CodSpeed Performance Report

Merging #2590 will not alter performance

Comparing fix-multiple-types-array-with-object-properties (e924436) with main (6ac97d8)

Summary

✅ 32 untouched
⏩ 3 skipped1

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@koxudaxi koxudaxi marked this pull request as ready for review December 3, 2025 12:48
@koxudaxi koxudaxi merged commit cd0c2d2 into main Dec 3, 2025
39 checks passed
@koxudaxi koxudaxi deleted the fix-multiple-types-array-with-object-properties branch December 3, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple types in array not well supported -> buggy parser

2 participants