Make CI dependency installation order match between workflows #557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated installation command to remove 'dev' dependencies.
delucchi-cmu
requested changes
Dec 3, 2025
| if [ -f docs/requirements.txt ]; then pip install -r docs/requirements.txt; fi | ||
| pip install . | ||
| uv pip install --system -e . | ||
| if [ -f requirements.txt ]; then uv pip install --system -r requirements.txt; fi |
Contributor
There was a problem hiding this comment.
Keep both the docs/requirements and requirements. All of the sphinx dependencies are currently in the docs/requirements file.
Member
Author
There was a problem hiding this comment.
Oops--copy and paste error, on it!
Contributor
|
And just remembered - you also need to tell readthedocs to look at all of the right requirements files. That is set up in |
Add conditional installation of documentation requirements.
delucchi-cmu
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Updating the dependency installation order in the build documentation workflow to match the order in the testing workflow. (This is also the order in the pre-commit, smoke test, and testing windows workflows).
This allows us to (temporarily) update a package in our requirements.txt file to point to a branch (eg, we are making concurrent changes to hats and hats-import like so). At the moment, the documentation workflow will just override the specified version and give our PR a big ol' ❌ :(
Also, this adds uv to match the other workflows.
Checklist
lincc-frameworks/python-project-templaterepo and not a downstream one instead.