Skip to content

feature: Make bitbucket build-status optional #1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feature: Make bitbucket build-status optional #1168

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dabf116
feature: Make bitbucket build-status optional
ThibautMarechal Nov 18, 2025
171ad0f
use bitbucket server version check instead of config by env variables
ThibautMarechal Nov 18, 2025
8796037
Revert "use bitbucket server version check instead of config by env v…
ThibautMarechal Nov 19, 2025
5abcdd7
Submit Build Status only on Bitbucket Cloud AML type
ThibautMarechal Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...thub/mc1arke/sonarqube/plugin/ce/pullrequest/bitbucket/BitbucketPullRequestDecorator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,10 @@ public DecorationResult decorateQualityGateStatus(AnalysisDetails analysisDetail

updateAnnotations(client, analysisDetails, reportKey);

BuildStatus buildStatus = new BuildStatus(analysisDetails.getQualityGateStatus() == QualityGate.Status.OK ? BuildStatus.State.SUCCESSFUL : BuildStatus.State.FAILED, reportKey, "SonarQube", analysisSummary.getDashboardUrl());
client.submitBuildStatus(analysisDetails.getCommitSha(),buildStatus);
if (!"true".equalsIgnoreCase(System.getenv("SONAR_BITBUCKET_SKIP_BUILD_STATUS"))) {
Copy link
Owner

@mc1arke mc1arke Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't something that appears to exist in Sonarqube's documentation, so we're diverging from how they're configured. Do they have a property they offer for allowing a similar configuration?

Copy link
Author

@ThibautMarechal ThibautMarechal Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, The Sonarqube's documentation don't mention submitting any build status, only code insight.
https://docs.sonarsource.com/sonarqube-server/10.7/devops-platform-integration/bitbucket-integration/bitbucket-server-integration#preventing-pull-request-merges-when-the-quality-gate-fails

Copy link
Author

@ThibautMarechal ThibautMarechal Nov 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some digging, I found that the feature of blocking a PR from code insight was released in the version 6.9 of Bitbucket.
If I do an additional http call to get the version of bitbucket, and based on that version only submitting a build-status if it's lower than 6.9 ?
The initial issue don't mention any bitbucket version at all.

BuildStatus buildStatus = new BuildStatus(analysisDetails.getQualityGateStatus() == QualityGate.Status.OK ? BuildStatus.State.SUCCESSFUL : BuildStatus.State.FAILED, reportKey, "SonarQube", analysisSummary.getDashboardUrl());
client.submitBuildStatus(analysisDetails.getCommitSha(),buildStatus);
}
} catch (IOException e) {
LOGGER.error("Could not decorate pull request for project {}", analysisDetails.getAnalysisProjectKey(), e);
}
Expand Down