Rework the mechanism for checking SME capabilities #26666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan Clohessy <jonathan.clohessy@arm.com>
edgchen1
reviewed
Nov 26, 2025
|
|
||
| // Boolean condition to determine if we can use SME2 | ||
| // By default we should try for SME2 first before falling back to SME. | ||
| inline const bool SMEInfo::CanUseSME2 = MLAS_CPUIDINFO::GetCPUIDInfo().HasArm_SME2(); |
Contributor
There was a problem hiding this comment.
CPUIDInfo::HasArm_SME2() already returns a cached bool. is it worth having another constant for the same value? admittedly, SMEInfo::CanUseSME2 is less to type, but it may be simpler to just have a single way of getting this information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Various parts of Onnxruntime and in particular MLAS with kleidiai enabled. We rely on cpu info checks for SME and/or SME2 this patch aims to simplify that process by adding a struct which gives easy to understand information and adding it to the relevant places in the code.
Additionally it gates qgemm_kleidiai.cpp properly against non sme2 hardware gaining access. This will address #26377 which raises one such instance of this occurring on a device with has SME1 support but not SME2